mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: disable flaky arm tests (#26046)

Browse source 
* tests: disable flaking test on all arm platforms

* tests: disable flaky did-change-theme-color tests on WOA
This commit is contained in:
John Kleinschmidt 2020-10-19 20:11:30 -04:00 • committed by GitHub
commit 4ce7ca6cfb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec-main/api-service-workers-spec.ts
View file

@ -7,6 +7,7 @@ import { v4 } from 'uuid';
import { AddressInfo } from 'net';
import { closeWindow } from './window-helpers';
import { emittedOnce, emittedNTimes } from './events-helpers';
import { ifdescribe } from './spec-helpers';
const partition = 'service-workers-spec';
const uuid = v4();
@ -65,7 +66,8 @@ describe('session.serviceWorkers', () => {
});
});
describe('getFromVersionID()', () => {
// TODO (jkleinsc) - reenable this test once https://github.com/electron/electron/issues/26043 is resolved
ifdescribe(!process.arch.includes('arm'))('getFromVersionID()', () => {
it('should report the correct script url and scope', async () => {
const eventInfo = await emittedOnce(ses.serviceWorkers, 'console-message', () => w.loadURL(`${baseUrl}/index.html`));
const details: Electron.MessageDetails = eventInfo[1];

3
spec-main/api-web-contents-spec.ts
View file

@ -1375,7 +1375,8 @@ describe('webContents module', () => {
}
});
describe('did-change-theme-color event', () => {
// TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved
ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('did-change-theme-color event', () => {
afterEach(closeAllWindows);
it('is triggered with correct theme color', (done) => {
const w = new BrowserWindow({ show: true });

3
spec/webview-spec.js
View file

@ -986,7 +986,8 @@ describe('<webview> tag', function () {
});
});
describe('did-change-theme-color event', () => {
// TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved
ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('did-change-theme-color event', () => {
it('emits when theme color changes', async () => {
loadWebView(webview, {
src: `file://${fixtures}/pages/theme-color.html`