mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

test: remove workaround for fixed Menu.closePopup issue (#37802)

Browse source
This commit is contained in:
David Sanders 2023-04-04 01:27:51 -07:00 • committed by GitHub
parent 0b4ef2b1e5
commit 4c8583c365
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
spec/api-menu-spec.ts
View file

@ -817,11 +817,8 @@ describe('Menu module', function () {
it('should emit menu-will-close event', (done) => { it('should emit menu-will-close event', (done) => {
menu.on('menu-will-close', () => { done(); }); menu.on('menu-will-close', () => { done(); });
menu.popup({ window: w }); menu.popup({ window: w });
// https://github.com/electron/electron/issues/19411
setTimeout().then(() => {
menu.closePopup(); menu.closePopup();
}); });
});
it('returns immediately', () => { it('returns immediately', () => {
const input = { window: w, x: 100, y: 101 }; const input = { window: w, x: 100, y: 101 };
@ -849,19 +846,13 @@ describe('Menu module', function () {
expect(x).to.equal(100); expect(x).to.equal(100);
expect(y).to.equal(101); expect(y).to.equal(101);
// https://github.com/electron/electron/issues/19411
setTimeout().then(() => {
menu.closePopup(); menu.closePopup();
}); });
});
it('works with a given BrowserWindow, no options, and a callback', (done) => { it('works with a given BrowserWindow, no options, and a callback', (done) => {
menu.popup({ window: w, callback: () => done() }); menu.popup({ window: w, callback: () => done() });
// https://github.com/electron/electron/issues/19411
setTimeout().then(() => {
menu.closePopup(); menu.closePopup();
}); });
});
it('prevents menu from getting garbage-collected when popuping', async () => { it('prevents menu from getting garbage-collected when popuping', async () => {
const menu = Menu.buildFromTemplate([{ role: 'paste' }]); const menu = Menu.buildFromTemplate([{ role: 'paste' }]);