mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: convert more tests to async / await (#24373)

Browse source
This commit is contained in:
Milan Burda 2020-07-01 21:14:38 +02:00 • committed by GitHub
parent 3cb833821a
commit 4c449fbc75
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 116 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

45
spec-main/api-app-spec.ts
View file

@ -5,6 +5,7 @@ import * as http from 'http';
import * as net from 'net';
import * as fs from 'fs';
import * as path from 'path';
import { promisify } from 'util';
import { app, BrowserWindow, Menu, session } from 'electron/main';
import { emittedOnce } from './events-helpers';
import { closeWindow, closeAllWindows } from './window-helpers';
@ -891,34 +892,24 @@ describe('app module', () => {
expect(app.isDefaultProtocolClient(protocol)).to.equal(false);
});
it('creates a registry entry for the protocol class', (done) => {
it('creates a registry entry for the protocol class', async () => {
app.setAsDefaultProtocolClient(protocol);
classesKey.keys((error: Error, keys: any[]) => {
if (error) throw error;
const exists = !!keys.find(key => key.key.includes(protocol));
expect(exists).to.equal(true);
done();
});
const keys = await promisify(classesKey.keys).call(classesKey) as any[];
const exists = !!keys.find(key => key.key.includes(protocol));
expect(exists).to.equal(true);
});
it('completely removes a registry entry for the protocol class', (done) => {
it('completely removes a registry entry for the protocol class', async () => {
app.setAsDefaultProtocolClient(protocol);
app.removeAsDefaultProtocolClient(protocol);
classesKey.keys((error: Error, keys: any[]) => {
if (error) throw error;
const exists = !!keys.find(key => key.key.includes(protocol));
expect(exists).to.equal(false);
done();
});
const keys = await promisify(classesKey.keys).call(classesKey) as any[];
const exists = !!keys.find(key => key.key.includes(protocol));
expect(exists).to.equal(false);
});
it('only unsets a class registry key if it contains other data', (done) => {
it('only unsets a class registry key if it contains other data', async () => {
app.setAsDefaultProtocolClient(protocol);
const protocolKey = new Winreg({
@ -926,18 +917,12 @@ describe('app module', () => {
key: `\\Software\\Classes\\${protocol}`
});
protocolKey.set('test-value', 'REG_BINARY', '123', () => {
app.removeAsDefaultProtocolClient(protocol);
await promisify(protocolKey.set).call(protocolKey, 'test-value', 'REG_BINARY', '123');
app.removeAsDefaultProtocolClient(protocol);
classesKey.keys((error: Error, keys: any[]) => {
if (error) throw error;
const exists = !!keys.find(key => key.key.includes(protocol));
expect(exists).to.equal(true);
done();
});
});
const keys = await promisify(classesKey.keys).call(classesKey) as any[];
const exists = !!keys.find(key => key.key.includes(protocol));
expect(exists).to.equal(true);
});
it('sets the default client such that getApplicationNameForProtocol returns Electron', () => {