mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: ensure that we bundle the correct version of @types/node (#19102)

Browse source
This commit is contained in:
Samuel Attard 2019-07-03 16:36:59 -07:00 • committed by GitHub
parent 5a1b661f42
commit 4b674c1daf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
npm/package.json
View file

@ -9,7 +9,7 @@
},
"dependencies": {
"@electron/get": "^1.0.1",
"@types/node": "^10.12.18",
"@types/node": "^12.0.12",
"extract-zip": "^1.0.3"
},
"engines": {

10
spec-main/types-spec.ts Normal file
View file

@ -0,0 +1,10 @@
import { expect } from 'chai'
describe('bundled @types/node', () => {
it('should match the major version of bundled node', () => {
expect(require('../npm/package.json').dependencies).to.have.property('@types/node')
const range = require('../npm/package.json').dependencies['@types/node']
expect(range).to.match(/^\^.+/, 'should allow any type dep in a major range')
expect(range.slice(1).split('.')[0]).to.equal(process.versions.node.split('.')[0])
})
})