mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: correctly serialize nativeImage/buffer with typeUtils (#23666)

Browse source 
* refactor: correctly serialize nativeImage/buffer with typeUtils

* test: add serialization specs

* fix: construct from dataURL

* test: test for dataURL specificity
This commit is contained in:
Shelley Vohr 2020-05-20 13:42:42 -07:00 • committed by GitHub
parent 33d6a99d40
commit 4b23a85475
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 166 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/browser/remote/server.ts
View file

@ -245,7 +245,7 @@ type MetaTypeFromRenderer = {
length: number
} | {
type: 'nativeimage',
value: { size: Size, buffer: Buffer, scaleFactor: number }[]
value: { size: Size, buffer: Buffer, scaleFactor: number, dataURL: string }[]
}
const fakeConstructor = (constructor: Function, name: string) =>
@ -266,13 +266,9 @@ const unwrapArgs = function (sender: electron.WebContents, frameId: number, cont
case 'nativeimage': {
const image = electron.nativeImage.createEmpty();
for (const rep of meta.value) {
const { buffer, size, scaleFactor } = rep;
image.addRepresentation({
buffer,
width: size.width,
height: size.height,
scaleFactor
});
const { size, scaleFactor, dataURL } = rep;
const { width, height } = size;
image.addRepresentation({ dataURL, scaleFactor, width, height });
}
return image;
}