mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Enable ignoring |rect| when calling BrowserWindow.capturePage.

Browse source
This commit is contained in:
Cheng Zhao 2013-11-22 14:29:20 +08:00
parent 3b4a45ac65
commit 4af802f215
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
browser/api/atom_api_window.cc
View file

@ -87,7 +87,7 @@ void Window::OnCapturePageDone(v8::Persistent<v8::Function> callback,
const std::vector<unsigned char>& data) { const std::vector<unsigned char>& data) {
v8::HandleScope scope; v8::HandleScope scope;
// TODO Use new Buffer API when we updated to node v0.12.x. // TODO(zcbenz): Use new Buffer API when we updated to node v0.12.x.
node::Buffer* buffer = node::Buffer::New( node::Buffer* buffer = node::Buffer::New(
reinterpret_cast<const char*>(data.data()), reinterpret_cast<const char*>(data.data()),
data.size()); data.size());
@ -501,7 +501,8 @@ v8::Handle<v8::Value> Window::CapturePage(const v8::Arguments& args) {
gfx::Rect rect; gfx::Rect rect;
v8::Persistent<v8::Function> callback; v8::Persistent<v8::Function> callback;
if (!FromV8Arguments(args, &rect, &callback)) if (!FromV8Arguments(args, &rect, &callback) &&
!FromV8Arguments(args, &callback))
return node::ThrowTypeError("Bad argument"); return node::ThrowTypeError("Bad argument");
self->window_->CapturePage(rect, base::Bind(&Window::OnCapturePageDone, self->window_->CapturePage(rect, base::Bind(&Window::OnCapturePageDone,