fix: misc-use-internal-linkage warnings (#44843)
* refactor: misc-use-internal-linkage warnings in context bridge move impl functions into anonymous namespace so that they're not visible to other compilation units: - ExposeAPIInWorld() - IsCalledFromMainWorld() - OverrideGlobalPropertyFromIsolatedWorld() - OverrideGlobalValueFromIsolatedWorld() - TraceKeyPath() * refactor: misc-use-internal-linkage warnings in skia util move impl details into anonymous namespace so that they're not visible to other compilation units: - struct ScaleFactorPair - kScaleFactorPairs[] - GetScaleFactorFromPath() - AddImageSkiaRepFromPath() * refactor: misc-use-internal-linkage warnings in printing util move impl details into anonymous namespace so that they're not visible to other compilation units: - GetFullPagePlugin() * refactor: misc-use-internal-linkage warnings in blijnk converter move impl details into anonymous namespace so that they're not visible to other compilation units: - GetKeyLocationCode() - ModifiersToArray() * refactor: misc-use-internal-linkage warnings in extrension system move impl details into anonymous namespace so that they're not visible to other compilation units: - ParseManifest() * refactor: misc-use-internal-linkage warnings in skia util move impl details into anonymous namespace so that they're not visible to other compilation units: - GetFrameTokenMap() - GetFrameTreeNodeIdMap() * refactor: misc-use-internal-linkage warnings in electron_api_utility_process.cc move impl details into anonymous namespace so that they're not visible to other compilation units: - GetAllUtilityProcessWrappers() * refactor: misc-use-internal-linkage warnings in electron_api_menu move impl details into anonymous namespace so that they're not visible to other compilation units: - InvokeBoolMethod() * refactor: misc-use-internal-linkage warnings in platform util move impl details into anonymous namespace so that they're not visible to other compilation units: - struct TrashItemResult - TrashItemOnBlockingThread()
This commit is contained in:
parent
4aa1855e39
commit
4a695d07c6
9 changed files with 54 additions and 14 deletions
|
@ -70,6 +70,8 @@ Menu::~Menu() {
|
|||
}
|
||||
}
|
||||
|
||||
namespace {
|
||||
|
||||
bool InvokeBoolMethod(const Menu* menu,
|
||||
const char* method,
|
||||
int command_id,
|
||||
|
@ -84,6 +86,8 @@ bool InvokeBoolMethod(const Menu* menu,
|
|||
return gin::ConvertFromV8(isolate, val, &ret) ? ret : default_value;
|
||||
}
|
||||
|
||||
} // namespace
|
||||
|
||||
bool Menu::IsCommandIdChecked(int command_id) const {
|
||||
return InvokeBoolMethod(this, "_isCommandIdChecked", command_id);
|
||||
}
|
||||
|
|
|
@ -44,6 +44,8 @@
|
|||
|
||||
namespace electron {
|
||||
|
||||
namespace {
|
||||
|
||||
base::IDMap<api::UtilityProcessWrapper*, base::ProcessId>&
|
||||
GetAllUtilityProcessWrappers() {
|
||||
static base::NoDestructor<
|
||||
|
@ -52,6 +54,8 @@ GetAllUtilityProcessWrappers() {
|
|||
return *s_all_utility_process_wrappers;
|
||||
}
|
||||
|
||||
} // namespace
|
||||
|
||||
namespace api {
|
||||
|
||||
gin::WrapperInfo UtilityProcessWrapper::kWrapperInfo = {
|
||||
|
|
|
@ -100,6 +100,8 @@ using FrameTreeNodeIdMap = std::unordered_map<content::FrameTreeNodeId,
|
|||
using FrameTokenMap =
|
||||
std::map<content::GlobalRenderFrameHostToken, WebFrameMain*>;
|
||||
|
||||
namespace {
|
||||
|
||||
FrameTreeNodeIdMap& GetFrameTreeNodeIdMap() {
|
||||
static base::NoDestructor<FrameTreeNodeIdMap> instance;
|
||||
return *instance;
|
||||
|
@ -109,6 +111,8 @@ FrameTokenMap& GetFrameTokenMap() {
|
|||
return *instance;
|
||||
}
|
||||
|
||||
} // namespace
|
||||
|
||||
// static
|
||||
WebFrameMain* WebFrameMain::FromFrameTreeNodeId(
|
||||
content::FrameTreeNodeId frame_tree_node_id) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue