From 4935e8567f25e54f47ce0a66f08190e85d8ab865 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Fri, 14 Jul 2017 10:07:06 -0700 Subject: [PATCH] Initialize level_ in initWithShell --- atom/browser/native_window_mac.mm | 4 ++-- spec/api-browser-window-spec.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm index 100baf96a07..30629a2f632 100644 --- a/atom/browser/native_window_mac.mm +++ b/atom/browser/native_window_mac.mm @@ -86,6 +86,7 @@ bool ScopedDisableResize::disable_resize_ = false; if ((self = [super init])) { shell_ = shell; is_zooming_ = false; + level_ = [shell_->GetNativeWindow() level]; } return self; } @@ -217,8 +218,7 @@ bool ScopedDisableResize::disable_resize_ = false; } - (void)windowDidDeminiaturize:(NSNotification*)notification { - NSWindow* window = shell_->GetNativeWindow(); - [window setLevel:level_]; + [shell_->GetNativeWindow() setLevel:level_]; shell_->NotifyWindowRestore(); } diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index 2b1fc4a86b5..b1c0cddab00 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -620,7 +620,7 @@ describe('BrowserWindow module', function () { }) }) - describe.only('BrowserWindow.alwaysOnTop() resets level on minimize', function () { + describe('BrowserWindow.alwaysOnTop() resets level on minimize', function () { if (process.platform !== 'darwin') { return }