From 48959d72f68668a46d647f157c0b7fa8db8ea6be Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Wed, 12 May 2021 11:59:20 -0700 Subject: [PATCH] build: unconditionally include stack_trace.h (#29110) --- patches/chromium/.patches | 1 + ...clude_of_stack_trace_h_unconditional.patch | 24 +++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 patches/chromium/make_include_of_stack_trace_h_unconditional.patch diff --git a/patches/chromium/.patches b/patches/chromium/.patches index a2cad75f83e3..e67c971e102c 100644 --- a/patches/chromium/.patches +++ b/patches/chromium/.patches @@ -106,3 +106,4 @@ extend_apply_webpreferences.patch fix_expose_decrementcapturercount_in_web_contents_impl.patch add_setter_for_browsermainloop_result_code.patch revert_roll_clang_llvmorg-13-init-7051-gdad5caa5-2.patch +make_include_of_stack_trace_h_unconditional.patch diff --git a/patches/chromium/make_include_of_stack_trace_h_unconditional.patch b/patches/chromium/make_include_of_stack_trace_h_unconditional.patch new file mode 100644 index 000000000000..d91176c28591 --- /dev/null +++ b/patches/chromium/make_include_of_stack_trace_h_unconditional.patch @@ -0,0 +1,24 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Samuel Attard +Date: Tue, 11 May 2021 20:41:00 -0700 +Subject: make include of stack_trace.h unconditional + +This conditional include throws goma for a loop for no real reason. +While we work on either upstreaming this or fixing the underlying goma +issue this makes our builds 33% faster during local testing (11m vs 18m). + +diff --git a/base/sequence_checker.h b/base/sequence_checker.h +index 50a548a759c2dc6d79978741a0c803500d53a9f8..cd5049e8bf59c51b890bcc332f9a1c5f0ec339c9 100644 +--- a/base/sequence_checker.h ++++ b/base/sequence_checker.h +@@ -10,9 +10,8 @@ + #include "base/strings/string_piece.h" + #include "build/build_config.h" + +-#if DCHECK_IS_ON() + #include "base/debug/stack_trace.h" +-#endif ++ + + // SequenceChecker is a helper class used to help verify that some methods of a + // class are called sequentially (for thread-safety). It supports thread safety