From 481f9b25a76af2ecab5f49f1e6a395441e7b26d5 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Thu, 26 Sep 2024 21:49:42 -0500 Subject: [PATCH] chore: remove unused nogncheck includes (#43991) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/app/electron_content_client.cc | 1 - shell/browser/api/electron_api_web_contents.cc | 4 ---- shell/browser/browser_linux.cc | 5 ++++- shell/browser/electron_browser_client.cc | 1 - shell/browser/extensions/electron_extensions_api_client.cc | 4 ---- shell/browser/notifications/linux/libnotify_notification.cc | 1 - shell/browser/ui/file_dialog_linux.cc | 2 +- shell/common/application_info_linux.cc | 1 - shell/common/platform_util_linux.cc | 1 - 9 files changed, 5 insertions(+), 15 deletions(-) diff --git a/shell/app/electron_content_client.cc b/shell/app/electron_content_client.cc index 5693a5353a10..8e8b18c17c15 100644 --- a/shell/app/electron_content_client.cc +++ b/shell/app/electron_content_client.cc @@ -35,7 +35,6 @@ #if BUILDFLAG(ENABLE_PDF_VIEWER) #include "components/pdf/common/constants.h" // nogncheck -#include "pdf/pdf.h" // nogncheck #include "shell/common/electron_constants.h" #endif // BUILDFLAG(ENABLE_PDF_VIEWER) diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc index 81a629764650..3d8b096b4e81 100644 --- a/shell/browser/api/electron_api_web_contents.cc +++ b/shell/browser/api/electron_api_web_contents.cc @@ -183,10 +183,6 @@ #endif #endif // BUILDFLAG(ENABLE_PRINTING) -#if BUILDFLAG(ENABLE_PDF_VIEWER) -#include "components/pdf/browser/pdf_document_helper.h" // nogncheck -#endif - #if BUILDFLAG(ENABLE_PLUGINS) #include "content/public/browser/plugin_service.h" #endif diff --git a/shell/browser/browser_linux.cc b/shell/browser/browser_linux.cc index 13fb661b146f..b61a4a4340ab 100644 --- a/shell/browser/browser_linux.cc +++ b/shell/browser/browser_linux.cc @@ -7,6 +7,10 @@ #include #include +#if BUILDFLAG(IS_LINUX) +#include +#endif + #include "base/command_line.h" #include "base/environment.h" #include "base/process/launch.h" @@ -21,7 +25,6 @@ #if BUILDFLAG(IS_LINUX) #include "shell/browser/linux/unity_service.h" -#include "ui/gtk/gtk_util.h" // nogncheck #endif namespace electron { diff --git a/shell/browser/electron_browser_client.cc b/shell/browser/electron_browser_client.cc index 8301212fea0f..93331bf4c414 100644 --- a/shell/browser/electron_browser_client.cc +++ b/shell/browser/electron_browser_client.cc @@ -32,7 +32,6 @@ #include "components/net_log/chrome_net_log.h" #include "components/network_hints/common/network_hints.mojom.h" #include "content/browser/keyboard_lock/keyboard_lock_service_impl.h" // nogncheck -#include "content/browser/site_instance_impl.h" // nogncheck #include "content/public/browser/browser_main_runner.h" #include "content/public/browser/browser_task_traits.h" #include "content/public/browser/client_certificate_delegate.h" diff --git a/shell/browser/extensions/electron_extensions_api_client.cc b/shell/browser/extensions/electron_extensions_api_client.cc index 1b24519e428f..d2bb0c887917 100644 --- a/shell/browser/extensions/electron_extensions_api_client.cc +++ b/shell/browser/extensions/electron_extensions_api_client.cc @@ -22,10 +22,6 @@ #include "shell/browser/printing/print_view_manager_electron.h" #endif -#if BUILDFLAG(ENABLE_PDF_VIEWER) -#include "components/pdf/browser/pdf_document_helper.h" // nogncheck -#endif - namespace extensions { class ElectronGuestViewManagerDelegate diff --git a/shell/browser/notifications/linux/libnotify_notification.cc b/shell/browser/notifications/linux/libnotify_notification.cc index c931328924ef..231ba25485a1 100644 --- a/shell/browser/notifications/linux/libnotify_notification.cc +++ b/shell/browser/notifications/linux/libnotify_notification.cc @@ -17,7 +17,6 @@ #include "shell/common/application_info.h" #include "shell/common/platform_util.h" #include "third_party/skia/include/core/SkBitmap.h" -#include "ui/gtk/gtk_util.h" // nogncheck namespace electron { diff --git a/shell/browser/ui/file_dialog_linux.cc b/shell/browser/ui/file_dialog_linux.cc index 0185e0ca1958..befbac20fe9b 100644 --- a/shell/browser/ui/file_dialog_linux.cc +++ b/shell/browser/ui/file_dialog_linux.cc @@ -17,8 +17,8 @@ #include "shell/common/gin_converters/file_path_converter.h" #include "shell/common/gin_helper/dictionary.h" #include "shell/common/gin_helper/promise.h" -#include "ui/gtk/select_file_dialog_linux_gtk.h" // nogncheck #include "ui/shell_dialogs/select_file_dialog.h" +#include "ui/shell_dialogs/select_file_policy.h" #include "ui/shell_dialogs/selected_file_info.h" namespace file_dialog { diff --git a/shell/common/application_info_linux.cc b/shell/common/application_info_linux.cc index f1f4e55ce019..d2cab1959720 100644 --- a/shell/common/application_info_linux.cc +++ b/shell/common/application_info_linux.cc @@ -12,7 +12,6 @@ #include "base/logging.h" #include "electron/electron_version.h" #include "shell/common/platform_util.h" -#include "ui/gtk/gtk_util.h" // nogncheck namespace { diff --git a/shell/common/platform_util_linux.cc b/shell/common/platform_util_linux.cc index 820135237e3e..6bd80cc15b1e 100644 --- a/shell/common/platform_util_linux.cc +++ b/shell/common/platform_util_linux.cc @@ -33,7 +33,6 @@ #include "dbus/message.h" #include "dbus/object_proxy.h" #include "shell/common/platform_util_internal.h" -#include "ui/gtk/gtk_util.h" // nogncheck #include "url/gurl.h" #define ELECTRON_TRASH "ELECTRON_TRASH"