mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: use Date.now() instead of +new Date() (#38901)

Browse source 
refactor: use Date.now()
This commit is contained in:
Milan Burda 2023-07-18 10:58:02 +02:00 committed by GitHub
parent 8874306dc0
commit 47951cc95b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
spec/api-content-tracing-spec.ts
View file

@ -128,10 +128,10 @@ ifdescribe(!(['arm', 'arm64', 'ia32'].includes(process.arch)))('contentTracing',
traceOptions: 'record-until-full' traceOptions: 'record-until-full'
}); });
{ {
const start = +new Date(); const start = Date.now();
let n = 0; let n = 0;
const f = () => {}; const f = () => {};
while (+new Date() - start < 200 || n < 500) { while (Date.now() - start < 200 || n < 500) {
await setTimeout(0); await setTimeout(0);
f(); f();
n++; n++;

2
spec/api-crash-reporter-spec.ts
View file

@ -426,7 +426,7 @@ ifdescribe(!isLinuxOnArm && !process.mas && !process.env.DISABLE_CRASH_REPORTER_
); );
expect(firstReport).to.not.be.null(); expect(firstReport).to.not.be.null();
expect(firstReport.date).to.be.an.instanceOf(Date); expect(firstReport.date).to.be.an.instanceOf(Date);
expect((+new Date()) - (+firstReport.date)).to.be.lessThan(30000); expect((Date.now()) - (+firstReport.date)).to.be.lessThan(30000);
}); });
}); });

12
spec/api-session-spec.ts
View file

@ -69,7 +69,7 @@ describe('session module', () => {
const name = '1'; const name = '1';
const value = '1'; const value = '1';
await cookies.set({ url, name, value, expirationDate: (+new Date()) / 1000 + 120 }); await cookies.set({ url, name, value, expirationDate: (Date.now()) / 1000 + 120 });
const c = (await cookies.get({ url }))[0]; const c = (await cookies.get({ url }))[0];
expect(c.name).to.equal(name); expect(c.name).to.equal(name);
expect(c.value).to.equal(value); expect(c.value).to.equal(value);
@ -121,7 +121,7 @@ describe('session module', () => {
const name = '1'; const name = '1';
const value = '1'; const value = '1';
await cookies.set({ url, name, value, expirationDate: (+new Date()) / 1000 + 120 }); await cookies.set({ url, name, value, expirationDate: (Date.now()) / 1000 + 120 });
const cs = await cookies.get({ domain: '127.0.0.1' }); const cs = await cookies.get({ domain: '127.0.0.1' });
expect(cs.some(c => c.name === name && c.value === value)).to.equal(true); expect(cs.some(c => c.name === name && c.value === value)).to.equal(true);
}); });
@ -150,7 +150,7 @@ describe('session module', () => {
const { cookies } = session.defaultSession; const { cookies } = session.defaultSession;
const name = 'DidOverwrite'; const name = 'DidOverwrite';
for (const value of ['No', 'Yes']) { for (const value of ['No', 'Yes']) {
await cookies.set({ url, name, value, expirationDate: (+new Date()) / 1000 + 120 }); await cookies.set({ url, name, value, expirationDate: (Date.now()) / 1000 + 120 });
const list = await cookies.get({ url }); const list = await cookies.get({ url });
expect(list.some(cookie => cookie.name === name && cookie.value === value)).to.equal(true); expect(list.some(cookie => cookie.name === name && cookie.value === value)).to.equal(true);
@ -162,7 +162,7 @@ describe('session module', () => {
const name = '2'; const name = '2';
const value = '2'; const value = '2';
await cookies.set({ url, name, value, expirationDate: (+new Date()) / 1000 + 120 }); await cookies.set({ url, name, value, expirationDate: (Date.now()) / 1000 + 120 });
await cookies.remove(url, name); await cookies.remove(url, name);
const list = await cookies.get({ url }); const list = await cookies.get({ url });
@ -177,7 +177,7 @@ describe('session module', () => {
const name = 'custom'; const name = 'custom';
const value = '1'; const value = '1';
await cookies.set({ url, name, value, expirationDate: (+new Date()) / 1000 + 120 }); await cookies.set({ url, name, value, expirationDate: (Date.now()) / 1000 + 120 });
const list = await cookies.get({ url }); const list = await cookies.get({ url });
expect(list).to.have.lengthOf(1); expect(list).to.have.lengthOf(1);
@ -192,7 +192,7 @@ describe('session module', () => {
const value = 'bar'; const value = 'bar';
const a = once(cookies, 'changed'); const a = once(cookies, 'changed');
await cookies.set({ url, name, value, expirationDate: (+new Date()) / 1000 + 120 }); await cookies.set({ url, name, value, expirationDate: (Date.now()) / 1000 + 120 });
const [, setEventCookie, setEventCause, setEventRemoved] = await a; const [, setEventCookie, setEventCause, setEventRemoved] = await a;
const b = once(cookies, 'changed'); const b = once(cookies, 'changed');

4
spec/lib/spec-helpers.ts
View file

@ -141,11 +141,11 @@ export async function repeatedly<T> (
opts?: { until?: (x: T) => boolean, timeLimit?: number } opts?: { until?: (x: T) => boolean, timeLimit?: number }
) { ) {
const { until = (x: T) => !!x, timeLimit = 10000 } = opts ?? {}; const { until = (x: T) => !!x, timeLimit = 10000 } = opts ?? {};
const begin = +new Date(); const begin = Date.now();
while (true) { while (true) {
const ret = await fn(); const ret = await fn();
if (until(ret)) { return ret; } if (until(ret)) { return ret; }
if (+new Date() - begin > timeLimit) { throw new Error(`repeatedly timed out (limit=${timeLimit})`); } if (Date.now() - begin > timeLimit) { throw new Error(`repeatedly timed out (limit=${timeLimit})`); }
} }
} }