mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: dont tag libcc when it does not exist in GN build

Browse source
This commit is contained in:
Samuel Attard 2018-09-28 15:58:54 +10:00
parent b0b9ebd448
commit 46932913d1
1 changed files with 0 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
script/release.js
View file

@ -6,7 +6,6 @@ const args = require('minimist')(process.argv.slice(2))
const fs = require('fs')
const { execSync } = require('child_process')
const GitHub = require('github')
const { GitProcess } = require('dugite')
const nugget = require('nugget')
const pkg = require('../package.json')
const pkgVersion = `v${pkg.version}`
@ -277,7 +276,6 @@ async function makeRelease (releaseToValidate) {
// Fetch latest version of release before verifying
draftRelease = await getDraftRelease(pkgVersion, true)
await validateReleaseAssets(draftRelease)
await tagLibCC()
await publishRelease(draftRelease)
console.log(`${pass} SUCCESS!!! Release has been published. Please run ` +
`"npm run publish-to-npm" to publish release to npm.`)
@ -446,23 +444,4 @@ async function validateChecksums (validationArgs) {
`shasums defined in ${validationArgs.shaSumFile}.`)
}
async function tagLibCC () {
const tag = `electron-${pkg.version}`
const libccDir = path.join(path.resolve(__dirname, '..'), 'vendor', 'libchromiumcontent')
console.log(`Tagging release ${tag}.`)
let tagDetails = await GitProcess.exec([ 'tag', '-a', '-m', tag, tag ], libccDir)
if (tagDetails.exitCode === 0) {
let pushDetails = await GitProcess.exec(['push', '--tags'], libccDir)
if (pushDetails.exitCode === 0) {
console.log(`${pass} Successfully tagged libchromiumcontent with ${tag}.`)
} else {
console.log(`${fail} Error pushing libchromiumcontent tag ${tag}: ` +
`${pushDetails.stderr}`)
}
} else {
console.log(`${fail} Error tagging libchromiumcontent with ${tag}: ` +
`${tagDetails.stderr}`)
}
}
makeRelease(args.validateRelease)