From 45fb3ec41d5ae36595183ab0baa17811eabb289d Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Fri, 7 Nov 2014 21:45:40 +0800 Subject: [PATCH] Don't overwrite files on S3 --- script/lib/util.py | 1 + script/upload.py | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/script/lib/util.py b/script/lib/util.py index 83c3e05148b4..355fec027c45 100644 --- a/script/lib/util.py +++ b/script/lib/util.py @@ -183,6 +183,7 @@ def s3put(bucket, access_key, secret_key, prefix, key_prefix, files): '--secret_key', secret_key, '--prefix', prefix, '--key_prefix', key_prefix, + '--no_overwrite', '--grant', 'public-read' ] + files diff --git a/script/upload.py b/script/upload.py index 2ad7f5ffd8ef..edfa4c963c97 100755 --- a/script/upload.py +++ b/script/upload.py @@ -59,19 +59,19 @@ def main(): upload_atom_shell(github, release_id, os.path.join(DIST_DIR, CHROMEDRIVER_NAME)) - # Upload node's headers to S3. - bucket, access_key, secret_key = s3_config() - upload_node(bucket, access_key, secret_key, ATOM_SHELL_VERSION) - if args.publish_release: - # Press the publish button. - publish_release(github, release_id) + # Upload node's headers to S3. + bucket, access_key, secret_key = s3_config() + upload_node(bucket, access_key, secret_key, ATOM_SHELL_VERSION) # Upload the SHASUMS.txt. execute([sys.executable, os.path.join(SOURCE_ROOT, 'script', 'upload-checksums.py'), '-v', ATOM_SHELL_VERSION]) + # Press the publish button. + publish_release(github, release_id) + def parse_args(): parser = argparse.ArgumentParser(description='upload distribution file')