diff --git a/spec/chromium-spec.js b/spec/chromium-spec.js index df9e2c3db646..7c3f9aace0be 100644 --- a/spec/chromium-spec.js +++ b/spec/chromium-spec.js @@ -70,6 +70,15 @@ describe('chromium feature', () => { }) }) + describe('accessing key names also used as Node.js module names', () => { + it('does not crash', (done) => { + w = new BrowserWindow({show: false}) + w.webContents.once('did-finish-load', () => { done() }) + w.webContents.once('crashed', () => done(new Error('WebContents crashed.'))) + w.loadURL(`file://${fixtures}/pages/external-string.html`) + }) + }) + describe('navigator.webkitGetUserMedia', () => { it('calls its callbacks', (done) => { navigator.webkitGetUserMedia({ diff --git a/spec/fixtures/pages/external-string.html b/spec/fixtures/pages/external-string.html new file mode 100644 index 000000000000..3d1dc19af9f3 --- /dev/null +++ b/spec/fixtures/pages/external-string.html @@ -0,0 +1 @@ + diff --git a/vendor/node b/vendor/node index 18aeda2077e7..e61694e449e6 160000 --- a/vendor/node +++ b/vendor/node @@ -1 +1 @@ -Subproject commit 18aeda2077e7fe1ef9d7557692dda2e4d6a61860 +Subproject commit e61694e449e62e36dfe243d266e6313a0a043d5c