mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: lazy load V8 module in browser/init (#18575)

Browse source
This commit is contained in:
Samuel Attard 2019-06-03 01:03:33 -07:00 committed by GitHub
parent bc527f6b51
commit 449d2752f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/browser/init.ts
View file

@ -2,7 +2,6 @@ import { Buffer } from 'buffer'
import * as fs from 'fs'
import * as path from 'path'
import * as util from 'util'
import * as v8 from 'v8'
const Module = require('module')
@ -141,9 +140,10 @@ if (packageJson.desktopName != null) {
app.setDesktopName(`${app.name}.desktop`)
}
// Set v8 flags
// Set v8 flags, delibrately lazy load so that apps that do not use this
// feature do not pay the price
if (packageJson.v8Flags != null) {
v8.setFlagsFromString(packageJson.v8Flags)
require('v8').setFlagsFromString(packageJson.v8Flags)
}
app._setDefaultAppPaths(packagePath)