mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Deprecate old S3 env vars

Browse source
This commit is contained in:
Kevin Sawicki 2016-05-24 17:33:44 -07:00
parent 1bdb9f3de0
commit 43f0dfd0ab
1 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
script/lib/config.py
View file

@ -44,12 +44,20 @@ def get_target_arch():
def get_chromedriver_version(): def get_chromedriver_version():
return 'v2.21' return 'v2.21'
def get_env_var(name):
value = os.environ.get('ELECTRON_' + name, '')
if not value:
# TODO Remove ATOM_SHELL_* fallback values
value = os.environ.get('ATOM_SHELL_' + name, '')
if value:
print 'Warning: Use $ELECTRON_' + name + ' instead of $ATOM_SHELL_' + name
return value
def s3_config(): def s3_config():
# TODO Remove ATOM_SHELL_* fallback values config = (get_env_var('S3_BUCKET'),
config = (os.environ.get('ELECTRON_S3_BUCKET', os.environ.get('ATOM_SHELL_S3_BUCKET', '')), get_env_var('S3_ACCESS_KEY'),
os.environ.get('ELECTRON_S3_ACCESS_KEY', os.environ.get('ATOM_SHELL_S3_ACCESS_KEY', '')), get_env_var('S3_SECRET_KEY'))
os.environ.get('ELECTRON_S3_SECRET_KEY', os.environ.get('ATOM_SHELL_S3_SECRET_KEY', '')))
message = ('Error: Please set the $ELECTRON_S3_BUCKET, ' message = ('Error: Please set the $ELECTRON_S3_BUCKET, '
'$ELECTRON_S3_ACCESS_KEY, and ' '$ELECTRON_S3_ACCESS_KEY, and '
'$ELECTRON_S3_SECRET_KEY environment variables') '$ELECTRON_S3_SECRET_KEY environment variables')