mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Move HTTPBad flags into SSLStatus user data

Browse source 
https://chromium-review.googlesource.com/c/chromium/src/+/709458
This commit is contained in:
deepak1556 2018-04-13 15:05:43 +05:30 • committed by Samuel Attard
parent 3f7bb61b7f
commit 43ca4d5bfd
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
chromium_src/chrome/browser/ssl/security_state_tab_helper.cc
View file

@ -59,8 +59,8 @@ void SecurityStateTabHelper::VisibleSecurityStateChanged() {
security_state::SecurityInfo security_info; security_state::SecurityInfo security_info;
GetSecurityInfo(&security_info); GetSecurityInfo(&security_info);
if (!security_info.displayed_password_field_on_http && if (!security_info.insecure_input_events.password_field_shown &&
!security_info.displayed_credit_card_field_on_http) { !security_info.insecure_input_events.credit_card_field_edited) {
return; return;
} }
@ -92,12 +92,12 @@ void SecurityStateTabHelper::VisibleSecurityStateChanged() {
web_contents()->GetMainFrame()->AddMessageToConsole( web_contents()->GetMainFrame()->AddMessageToConsole(
content::CONSOLE_MESSAGE_LEVEL_WARNING, warning); content::CONSOLE_MESSAGE_LEVEL_WARNING, warning);
if (security_info.displayed_credit_card_field_on_http) { if (security_info.insecure_input_events.credit_card_field_edited) {
UMA_HISTOGRAM_BOOLEAN( UMA_HISTOGRAM_BOOLEAN(
"Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard", "Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard",
warning_is_user_visible); warning_is_user_visible);
} }
if (security_info.displayed_password_field_on_http) { if (security_info.insecure_input_events.password_field_shown) {
UMA_HISTOGRAM_BOOLEAN( UMA_HISTOGRAM_BOOLEAN(
"Security.HTTPBad.UserWarnedAboutSensitiveInput.Password", "Security.HTTPBad.UserWarnedAboutSensitiveInput.Password",
warning_is_user_visible); warning_is_user_visible);