mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove all usages of the legacy request module (#30492)

Browse source 
* Replaces request with got
* Replaces nugget with got streams
* Replaces request in docs with got
* Upgrades dugite to drop requests dependency
This commit is contained in:
Samuel Attard 2021-08-12 10:34:49 -07:00 • committed by GitHub
parent 08ff1c2cbf
commit 439e83de6c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 238 additions and 664 deletions
Download patch file Download diff file Expand all files Collapse all files

37
script/release/ci-release-build.js
View file

@ -1,7 +1,7 @@
if (!process.env.CI) require('dotenv-safe').load();
const assert = require('assert');
const request = require('request');
const got = require('got');
const BUILD_APPVEYOR_URL = 'https://ci.appveyor.com/api/builds';
const CIRCLECI_PIPELINE_URL = 'https://circleci.com/api/v2/project/gh/electron/electron/pipeline';
@ -35,31 +35,18 @@ const vstsArmJobs = [
let jobRequestedCount = 0;
async function makeRequest (requestOptions, parseResponse) {
return new Promise((resolve, reject) => {
request(requestOptions, (err, res, body) => {
if (!err && res.statusCode >= 200 && res.statusCode < 300) {
if (parseResponse) {
const build = JSON.parse(body);
resolve(build);
} else {
resolve(body);
}
} else {
console.error('Error occurred while requesting:', requestOptions.url);
if (parseResponse) {
try {
console.log('Error: ', `(status ${res.statusCode})`, err || JSON.parse(res.body));
} catch (err) {
console.log('Error: ', `(status ${res.statusCode})`, res.body);
}
} else {
console.log('Error: ', `(status ${res.statusCode})`, err || res.body);
}
reject(err);
}
});
async function makeRequest ({ auth, url, headers, body, method }) {
const response = await got(url, {
headers,
body,
method,
auth: auth ? `${auth.username}:${auth.password}` : undefined
});
if (response.statusCode !== 200) {
console.error('Error: ', `(status ${response.statusCode})`, response.body);
throw new Error(`Unexpected status code ${response.statusCode} from ${url}`);
}
return JSON.parse(response.body);
}
async function circleCIcall (targetBranch, workflowName, options) {