mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: multiple dock icons when calling dock.show/hide (#25269)

Browse source 
* fix: mulitple dock icons when calling dock.show/hide

* test: run dock.show tests after dock.hide tests
This commit is contained in:
Cheng Zhao 2020-09-03 20:46:24 +09:00 • committed by GitHub
parent bda6378685
commit 43485b8705
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
spec-main/api-app-spec.ts
View file

@ -1437,6 +1437,16 @@ describe('app module', () => {
});
});
describe('dock.hide', () => {
it('should not throw', () => {
app.dock.hide();
expect(app.dock.isVisible()).to.equal(false);
});
});
// Note that dock.show tests should run after dock.hide tests, to work
// around a bug of macOS.
// See https://github.com/electron/electron/pull/25269 for more.
describe('dock.show', () => {
it('should not throw', () => {
return app.dock.show().then(() => {
@ -1452,13 +1462,6 @@ describe('app module', () => {
await expect(app.dock.show()).to.eventually.be.fulfilled.equal(undefined);
});
});
describe('dock.hide', () => {
it('should not throw', () => {
app.dock.hide();
expect(app.dock.isVisible()).to.equal(false);
});
});
});
describe('whenReady', () => {