fix: destroy url loader wrapper when JS env exits (#44730)
* fix: destroy url loader wrapper when JS env exits Co-authored-by: deepak1556 <hop2deep@gmail.com> * Revert "fix: destroy url loader wrapper when JS env exits" This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c. Co-authored-by: deepak1556 <hop2deep@gmail.com> * Revert "Revert "fix: destroy url loader wrapper when JS env exits"" This reverts commit 4b401b03c62aca79498660f995825491ae52f179. Co-authored-by: deepak1556 <hop2deep@gmail.com> * fix: double free of JSChunkedDataPipeGetter Co-authored-by: deepak1556 <hop2deep@gmail.com> * fix: crash on process exit after stream completes Co-authored-by: deepak1556 <hop2deep@gmail.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>
This commit is contained in:
parent
50edc9bfe2
commit
42c88eba7c
2 changed files with 14 additions and 7 deletions
|
@ -22,6 +22,7 @@
|
|||
#include "services/network/public/mojom/url_loader_network_service_observer.mojom.h"
|
||||
#include "services/network/public/mojom/url_response_head.mojom.h"
|
||||
#include "shell/browser/event_emitter_mixin.h"
|
||||
#include "shell/common/gin_helper/cleaned_up_at_exit.h"
|
||||
#include "url/gurl.h"
|
||||
#include "v8/include/v8.h"
|
||||
|
||||
|
@ -47,6 +48,7 @@ namespace electron::api {
|
|||
class SimpleURLLoaderWrapper final
|
||||
: public gin::Wrappable<SimpleURLLoaderWrapper>,
|
||||
public gin_helper::EventEmitterMixin<SimpleURLLoaderWrapper>,
|
||||
public gin_helper::CleanedUpAtExit,
|
||||
private network::SimpleURLLoaderStreamConsumer,
|
||||
private network::mojom::URLLoaderNetworkServiceObserver {
|
||||
public:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue