mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: prevent double-destroy of window (#16512)

Browse source
This commit is contained in:
trop[bot] 2019-01-24 14:56:11 +01:00 committed by Alexey Kuzmin
parent 3c97c90621
commit 42acbec1c8
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
atom/browser/api/atom_api_browser_window.cc
View file

@ -183,7 +183,14 @@ bool BrowserWindow::OnMessageReceived(const IPC::Message& message,
} }
void BrowserWindow::OnCloseContents() { void BrowserWindow::OnCloseContents() {
DCHECK(web_contents()); // On some machines it may happen that the window gets destroyed for twice,
// checking web_contents() can effectively guard against that.
// https://github.com/electron/electron/issues/16202.
//
// TODO(zcbenz): We should find out the root cause and improve the closing
// procedure of BrowserWindow.
if (!web_contents())
return;
// Close all child windows before closing current window. // Close all child windows before closing current window.
v8::Locker locker(isolate()); v8::Locker locker(isolate());