mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: change some for loops to range-based (#26182)

Browse source
This commit is contained in:
David Sanders 2020-10-27 10:22:24 -07:00 • committed by GitHub
parent d8167ce138
commit 422190e1ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/common/api/electron_api_v8_util.cc
View file

@ -122,9 +122,9 @@ void ClearWeaklyTrackedValues() {
std::vector<v8::Local<v8::Value>> GetWeaklyTrackedValues(v8::Isolate* isolate) {
std::vector<v8::Local<v8::Value>> locals;
for (size_t i = 0; i < weakly_tracked_values.size(); i++) {
if (!weakly_tracked_values[i].IsEmpty())
locals.push_back(weakly_tracked_values[i].Get(isolate));
for (const auto& value : weakly_tracked_values) {
if (!value.IsEmpty())
locals.push_back(value.Get(isolate));
}
return locals;
}

5
shell/common/api/electron_bindings.cc
View file

@ -109,10 +109,7 @@ void ElectronBindings::ActivateUVLoop(v8::Isolate* isolate) {
// static
void ElectronBindings::OnCallNextTick(uv_async_t* handle) {
auto* self = static_cast<ElectronBindings*>(handle->data);
for (std::list<node::Environment*>::const_iterator it =
self->pending_next_ticks_.begin();
it != self->pending_next_ticks_.end(); ++it) {
node::Environment* env = *it;
for (auto* env : self->pending_next_ticks_) {
gin_helper::Locker locker(env->isolate());
v8::Context::Scope context_scope(env->context());
v8::HandleScope handle_scope(env->isolate());