mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Return null in window.open if failed to open new window, fixes #1067

Browse source
This commit is contained in:
Cheng Zhao 2015-01-28 21:07:57 -08:00
parent 8947d54cc9
commit 4217b70331
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/renderer/lib/override.coffee
View file

@ -42,7 +42,11 @@ window.open = (url, frameName='', features='') ->
options.height ?= 600
guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options
new FakeWindow(guestId)
if guestId
new FakeWindow(guestId)
else
console.error 'It is not allowed to open new window from this WebContents'
null
# Use the dialog API to implement alert().
window.alert = (message, title='') ->