mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: promisify win.capturePage() (#15743)

Browse source 
* feat: promisify win.capturePage

* mark optional arg correctly

* Add to breaking changes doc

* properly deprecate win.capturePage

* remove change from api-contract

* document both callback and promise versions

* address docs feedback

* update promisification progress doc
This commit is contained in:
Shelley Vohr 2018-11-27 23:50:53 -05:00 • committed by GitHub
parent 73fbb69c50
commit 41c2685204
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 74 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/common/api/deprecate.js
View file

@ -68,8 +68,8 @@ const deprecate = {
},
promisify: (promise, cb) => {
const oldName = `${promise.name} with callbacks`
const newName = `${promise.name} with Promises`
const oldName = `function with callbacks`
const newName = `function with Promises`
const warn = warnOnce(oldName, newName)
if (typeof cb !== 'function') return promise