mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: modify uploaded assets for win-ia32 (#33699)

Browse source 
* chore: filter correct symbol files

* chore: upload correct assets
This commit is contained in:
Keeley Hammond 2022-04-11 11:02:01 -07:00 committed by GitHub
parent 9d6e6c45c1
commit 41c1a7e318
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
appveyor.yml
View file

@ -182,9 +182,11 @@ build_script:
ninja -C out/Default electron:electron_symbols ninja -C out/Default electron:electron_symbols
} }
- ps: >- - ps: >-
if ($env:GN_CONFIG -eq 'release' -And $env:TARGET_ARCH -ne 'ia32') { if ($env:GN_CONFIG -eq 'release') {
python electron\script\zip-symbols.py if ($env:TARGET_ARCH -ne 'ia32') {
appveyor-retry appveyor PushArtifact out/Default/symbols.zip python electron\script\zip-symbols.py
appveyor-retry appveyor PushArtifact out/Default/symbols.zip
}
} else { } else {
# It's useful to have pdb files when debugging testing builds that are # It's useful to have pdb files when debugging testing builds that are
# built on CI. # built on CI.

2
script/release/release.js
View file

@ -133,8 +133,8 @@ function assetsForVersion (version, validatingRelease) {
`electron-${version}-mas-arm64-dsym-snapshot.zip`, `electron-${version}-mas-arm64-dsym-snapshot.zip`,
`electron-${version}-mas-arm64-symbols.zip`, `electron-${version}-mas-arm64-symbols.zip`,
`electron-${version}-mas-arm64.zip`, `electron-${version}-mas-arm64.zip`,
`electron-${version}-win32-ia32-pdb.zip`,
// TODO(jkleinsc) Symbol generation on 32-bit Windows is temporarily disabled due to failures // TODO(jkleinsc) Symbol generation on 32-bit Windows is temporarily disabled due to failures
// `electron-${version}-win32-ia32-pdb.zip`,
// `electron-${version}-win32-ia32-symbols.zip`, // `electron-${version}-win32-ia32-symbols.zip`,
`electron-${version}-win32-ia32.zip`, `electron-${version}-win32-ia32.zip`,
`electron-${version}-win32-x64-pdb.zip`, `electron-${version}-win32-x64-pdb.zip`,

2
script/release/uploaders/upload.py
View file

@ -76,7 +76,7 @@ def main():
shutil.copy2(os.path.join(OUT_DIR, 'dist.zip'), electron_zip) shutil.copy2(os.path.join(OUT_DIR, 'dist.zip'), electron_zip)
upload_electron(release, electron_zip, args) upload_electron(release, electron_zip, args)
if get_target_arch() != 'mips64el': if get_target_arch() != 'mips64el':
if get_target_arch() != 'ia32' and PLATFORM != 'win32': if (get_target_arch() != 'ia32' or PLATFORM != 'win32'):
symbols_zip = os.path.join(OUT_DIR, SYMBOLS_NAME) symbols_zip = os.path.join(OUT_DIR, SYMBOLS_NAME)
shutil.copy2(os.path.join(OUT_DIR, 'symbols.zip'), symbols_zip) shutil.copy2(os.path.join(OUT_DIR, 'symbols.zip'), symbols_zip)
upload_electron(release, symbols_zip, args) upload_electron(release, symbols_zip, args)