mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove banned std::to_string() calls (#41087)

Browse source 
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()

* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()

* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()

* refactor: do not use banned std::to_string() in SetCrashKey()

* chore: remove unused #include
This commit is contained in:
Charles Kerr 2024-01-24 16:43:31 -06:00 • committed by GitHub
parent d13a93fb61
commit 4164ef93ad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 31 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/common/api/electron_api_url_loader.cc
View file

@ -15,6 +15,7 @@
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "base/sequence_checker.h"
#include "base/strings/string_number_conversions.h"
#include "gin/handle.h"
#include "gin/object_template_builder.h"
#include "gin/wrappable.h"
@ -263,7 +264,7 @@ class JSChunkedDataPipeGetter : public gin::Wrappable<JSChunkedDataPipeGetter>,
promise.Resolve();
} else {
promise.RejectWithErrorMessage("mojo result not ok: " +
std::to_string(result));
base::NumberToString(result));
Finished();
}
}