refactor: remove banned std::to_string() calls (#41087)
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo() * refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED() * refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete() * refactor: do not use banned std::to_string() in SetCrashKey() * chore: remove unused #include
This commit is contained in:
parent
d13a93fb61
commit
4164ef93ad
18 changed files with 31 additions and 35 deletions
|
@ -7,6 +7,7 @@
|
|||
#include <string_view>
|
||||
#include <utility>
|
||||
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "chrome/browser/browser_process.h"
|
||||
#include "content/public/browser/console_message.h"
|
||||
#include "content/public/browser/storage_partition.h"
|
||||
|
@ -120,7 +121,7 @@ v8::Local<v8::Value> ServiceWorkerContext::GetAllRunningWorkerInfo(
|
|||
service_worker_context_->GetRunningServiceWorkerInfos();
|
||||
for (const auto& iter : info_map) {
|
||||
builder.Set(
|
||||
std::to_string(iter.first),
|
||||
base::NumberToString(iter.first),
|
||||
ServiceWorkerRunningInfoToDict(isolate, std::move(iter.second)));
|
||||
}
|
||||
return builder.Build();
|
||||
|
|
|
@ -16,7 +16,6 @@
|
|||
#include "base/files/file_path.h"
|
||||
#include "base/files/file_util.h"
|
||||
#include "base/memory/raw_ptr.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util.h"
|
||||
#include "base/strings/stringprintf.h"
|
||||
#include "base/uuid.h"
|
||||
|
|
|
@ -16,7 +16,6 @@
|
|||
#include "base/i18n/rtl.h"
|
||||
#include "base/mac/mac_util.h"
|
||||
#include "base/mac/mac_util.mm"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/sys_string_conversions.h"
|
||||
#include "chrome/browser/browser_process.h"
|
||||
#include "net/base/mac/url_conversions.h"
|
||||
|
|
|
@ -15,6 +15,7 @@
|
|||
#include "base/no_destructor.h"
|
||||
#include "base/path_service.h"
|
||||
#include "base/strings/escape.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util.h"
|
||||
#include "chrome/common/chrome_paths.h"
|
||||
#include "chrome/common/pref_names.h"
|
||||
|
|
|
@ -12,7 +12,6 @@
|
|||
|
||||
#include "base/command_line.h"
|
||||
#include "base/containers/contains.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util.h"
|
||||
#include "base/strings/stringprintf.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
|
|
|
@ -15,6 +15,8 @@
|
|||
|
||||
#include "base/environment.h"
|
||||
#include "base/logging.h"
|
||||
#include "base/strings/strcat.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util_win.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
#include "content/public/browser/browser_task_traits.h"
|
||||
|
@ -38,23 +40,22 @@ using Microsoft::WRL::Wrappers::HStringReference;
|
|||
|
||||
namespace winui = ABI::Windows::UI;
|
||||
|
||||
#define RETURN_IF_FAILED(hr) \
|
||||
do { \
|
||||
HRESULT _hrTemp = hr; \
|
||||
if (FAILED(_hrTemp)) { \
|
||||
return _hrTemp; \
|
||||
} \
|
||||
#define RETURN_IF_FAILED(hr) \
|
||||
do { \
|
||||
if (const HRESULT _hrTemp = hr; FAILED(_hrTemp)) { \
|
||||
return _hrTemp; \
|
||||
} \
|
||||
} while (false)
|
||||
#define REPORT_AND_RETURN_IF_FAILED(hr, msg) \
|
||||
do { \
|
||||
HRESULT _hrTemp = hr; \
|
||||
std::string _msgTemp = msg; \
|
||||
if (FAILED(_hrTemp)) { \
|
||||
std::string _err = _msgTemp + ",ERROR " + std::to_string(_hrTemp); \
|
||||
DebugLog(_err); \
|
||||
Notification::NotificationFailed(_err); \
|
||||
return _hrTemp; \
|
||||
} \
|
||||
|
||||
#define REPORT_AND_RETURN_IF_FAILED(hr, msg) \
|
||||
do { \
|
||||
if (const HRESULT _hrTemp = hr; FAILED(_hrTemp)) { \
|
||||
std::string _err = \
|
||||
base::StrCat({msg, ", ERROR ", base::NumberToString(_hrTemp)}); \
|
||||
DebugLog(_err); \
|
||||
Notification::NotificationFailed(_err); \
|
||||
return _hrTemp; \
|
||||
} \
|
||||
} while (false)
|
||||
|
||||
namespace electron {
|
||||
|
|
|
@ -11,7 +11,6 @@
|
|||
|
||||
#include "base/logging.h"
|
||||
#include "base/stl_util.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_split.h"
|
||||
#include "base/strings/string_util.h"
|
||||
#include "shell/common/keyboard_util.h"
|
||||
|
|
|
@ -17,6 +17,7 @@
|
|||
#include "base/metrics/histogram.h"
|
||||
#include "base/stl_util.h"
|
||||
#include "base/strings/pattern.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util.h"
|
||||
#include "base/strings/stringprintf.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
|
|
|
@ -16,7 +16,6 @@
|
|||
#include "base/json/json_writer.h"
|
||||
#include "base/strings/escape.h"
|
||||
#include "base/strings/pattern.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
#include "base/values.h"
|
||||
#include "build/build_config.h"
|
||||
|
|
|
@ -7,7 +7,6 @@
|
|||
#include <objbase.h>
|
||||
|
||||
#include "base/logging.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util_win.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
#include "base/win/windows_version.h"
|
||||
|
|
|
@ -10,7 +10,6 @@
|
|||
#include "base/containers/contains.h"
|
||||
#include "base/functional/bind.h"
|
||||
#include "base/observer_list.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/string_util.h"
|
||||
#include "base/strings/stringprintf.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
|
|
|
@ -13,7 +13,6 @@
|
|||
#include "base/command_line.h"
|
||||
#include "base/containers/fixed_flat_map.h"
|
||||
#include "base/memory/ptr_util.h"
|
||||
#include "base/strings/string_number_conversions.h"
|
||||
#include "base/strings/utf_string_conversions.h"
|
||||
#include "cc/base/switches.h"
|
||||
#include "content/public/browser/render_frame_host.h"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue