mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: stream protocols sometimes flake out (#21113)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-11-18 10:47:29 -08:00 • committed by GitHub
parent f4371b3f03
commit 4045852e6f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
shell/browser/net/node_stream_loader.cc
View file

@ -26,10 +26,7 @@ NodeStreamLoader::NodeStreamLoader(network::ResourceResponseHead head,
base::BindOnce(&NodeStreamLoader::NotifyComplete, base::BindOnce(&NodeStreamLoader::NotifyComplete,
weak_factory_.GetWeakPtr(), net::ERR_FAILED)); weak_factory_.GetWeakPtr(), net::ERR_FAILED));
// PostTask since it might destruct. Start(std::move(head));
base::SequencedTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(&NodeStreamLoader::Start,
weak_factory_.GetWeakPtr(), std::move(head)));
} }
NodeStreamLoader::~NodeStreamLoader() { NodeStreamLoader::~NodeStreamLoader() {
@ -44,10 +41,6 @@ NodeStreamLoader::~NodeStreamLoader() {
node::MakeCallback(isolate_, emitter_.Get(isolate_), "removeListener", node::MakeCallback(isolate_, emitter_.Get(isolate_), "removeListener",
node::arraysize(args), args, {0, 0}); node::arraysize(args), args, {0, 0});
} }
// Release references.
emitter_.Reset();
buffer_.Reset();
} }
void NodeStreamLoader::Start(network::ResourceResponseHead head) { void NodeStreamLoader::Start(network::ResourceResponseHead head) {