diff --git a/atom/app/atom_main_delegate.cc b/atom/app/atom_main_delegate.cc index 2eeb69dbe7f5..82b3559fb9f0 100644 --- a/atom/app/atom_main_delegate.cc +++ b/atom/app/atom_main_delegate.cc @@ -95,9 +95,10 @@ bool AtomMainDelegate::BasicStartupComplete(int* exit_code) { logging::SetLogItems(true, false, true, false); // Enable convient stack printing. - bool enable_stack_dumping = env->HasVar("ELECTRON_ENABLE_STACK_DUMPING"); #if defined(DEBUG) && defined(OS_LINUX) - enable_stack_dumping = true; + bool enable_stack_dumping = true; +#else + bool enable_stack_dumping = env->HasVar("ELECTRON_ENABLE_STACK_DUMPING"); #endif if (enable_stack_dumping) base::debug::EnableInProcessStackDumping(); diff --git a/atom/browser/atom_browser_main_parts_posix.cc b/atom/browser/atom_browser_main_parts_posix.cc index 8c96f91bfe68..d208ea8b7447 100644 --- a/atom/browser/atom_browser_main_parts_posix.cc +++ b/atom/browser/atom_browser_main_parts_posix.cc @@ -119,9 +119,8 @@ void ShutdownDetector::ThreadMain() { int signal; size_t bytes_read = 0; - ssize_t ret; do { - ret = HANDLE_EINTR( + ssize_t ret = HANDLE_EINTR( read(shutdown_fd_, reinterpret_cast(&signal) + bytes_read, sizeof(signal) - bytes_read)); diff --git a/atom/browser/atom_web_ui_controller_factory.cc b/atom/browser/atom_web_ui_controller_factory.cc index d113e656084a..3262dc974095 100644 --- a/atom/browser/atom_web_ui_controller_factory.cc +++ b/atom/browser/atom_web_ui_controller_factory.cc @@ -52,7 +52,7 @@ AtomWebUIControllerFactory::CreateWebUIControllerForURL(content::WebUI* web_ui, if (url.host() == kPdfViewerUIHost) { base::StringPairs toplevel_params; base::SplitStringIntoKeyValuePairs(url.query(), '=', '&', &toplevel_params); - std::string stream_id, src; + std::string src; const net::UnescapeRule::Type unescape_rules = net::UnescapeRule::SPACES | net::UnescapeRule::PATH_SEPARATORS | diff --git a/atom/browser/osr/osr_render_widget_host_view.cc b/atom/browser/osr/osr_render_widget_host_view.cc index a2f54076657f..34faa68acca2 100644 --- a/atom/browser/osr/osr_render_widget_host_view.cc +++ b/atom/browser/osr/osr_render_widget_host_view.cc @@ -194,7 +194,7 @@ class AtomCopyFrameGenerator { void OnCopyFrameCaptureSuccess( const gfx::Rect& damage_rect, - std::shared_ptr bitmap) { + const std::shared_ptr& bitmap) { base::AutoLock lock(onPaintLock_); view_->OnPaint(damage_rect, *bitmap); } diff --git a/brightray/browser/net/devtools_network_protocol_handler.cc b/brightray/browser/net/devtools_network_protocol_handler.cc index 715b2c540ec2..caf738435fdf 100644 --- a/brightray/browser/net/devtools_network_protocol_handler.cc +++ b/brightray/browser/net/devtools_network_protocol_handler.cc @@ -72,10 +72,10 @@ std::unique_ptr CreateFailureResponse(int id, const std::string& param) { auto response = base::MakeUnique(); auto error_object = base::MakeUnique(); - response->Set(kError, std::move(error_object)); error_object->SetInteger(params::kErrorCode, kErrorInvalidParams); error_object->SetString(params::kErrorMessage, base::StringPrintf("Missing or Invalid '%s' parameter", param.c_str())); + response->Set(kError, std::move(error_object)); return response; }