mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

perf: avoid redundant map lookup in ElectronBrowserContext::From() (#46062)

Browse source 
perf: avoid redundant map lookup in ElectronBrowserContext::FromPath()

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-03-15 13:46:58 -05:00 • committed by GitHub
parent 463e0d0ab7
commit 3faedae91c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

31
shell/browser/electron_browser_context.cc
View file

@ -833,34 +833,23 @@ ElectronBrowserContext* ElectronBrowserContext::From(
const std::string& partition, const std::string& partition,
bool in_memory, bool in_memory,
base::Value::Dict options) { base::Value::Dict options) {
PartitionKey key(partition, in_memory); auto& context = browser_context_map()[PartitionKey(partition, in_memory)];
ElectronBrowserContext* browser_context = browser_context_map()[key].get(); if (!context) {
if (browser_context) { context.reset(new ElectronBrowserContext{std::cref(partition), in_memory,
return browser_context; std::move(options)});
} }
return context.get();
auto* new_context = new ElectronBrowserContext(std::cref(partition),
in_memory, std::move(options));
browser_context_map()[key] =
std::unique_ptr<ElectronBrowserContext>(new_context);
return new_context;
} }
ElectronBrowserContext* ElectronBrowserContext::FromPath( ElectronBrowserContext* ElectronBrowserContext::FromPath(
const base::FilePath& path, const base::FilePath& path,
base::Value::Dict options) { base::Value::Dict options) {
PartitionKey key(path); auto& context = browser_context_map()[PartitionKey(path)];
if (!context) {
ElectronBrowserContext* browser_context = browser_context_map()[key].get(); context.reset(
if (browser_context) { new ElectronBrowserContext{std::cref(path), false, std::move(options)});
return browser_context;
} }
return context.get();
auto* new_context =
new ElectronBrowserContext(std::cref(path), false, std::move(options));
browser_context_map()[key] =
std::unique_ptr<ElectronBrowserContext>(new_context);
return new_context;
} }
} // namespace electron } // namespace electron