mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: race condition in NodeStreamLoader (#19811)

Browse source 
* fix: race condition in NodeStreamLoader

* nit: add comments
This commit is contained in:
Heilig Benedek 2019-08-21 05:23:46 +02:00 • committed by Cheng Zhao
parent b7defaaf6a
commit 3f49f984e6
2 changed files with 24 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
shell/browser/net/node_stream_loader.h
View file

@ -39,6 +39,7 @@ class NodeStreamLoader : public network::mojom::URLLoader {
using EventCallback = base::RepeatingCallback<void()>;
void Start(network::ResourceResponseHead head);
void NotifyReadable();
void NotifyComplete(int result);
void ReadMore();
void DidWrite(MojoResult result);
@ -68,11 +69,19 @@ class NodeStreamLoader : public network::mojom::URLLoader {
// Whether we are in the middle of write.
bool is_writing_ = false;
// Whether we are in the middle of a stream.read().
bool is_reading_ = false;
// When NotifyComplete is called while writing, we will save the result and
// quit with it after the write is done.
bool ended_ = false;
int result_ = net::OK;
// When the stream emits the readable event, we only want to start reading
// data if the stream was not readable before, so we store the state in a
// flag.
bool readable_ = false;
// Store the V8 callbacks to unsubscribe them later.
std::map<std::string, v8::Global<v8::Value>> handlers_;