From 3f40e93ba7b1eb70c970be073bb3c91c46f24fef Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 20 Jun 2018 12:51:36 -0700 Subject: [PATCH] chore: fix chromium-style errors in frame_subscriber The chromium-style linter we run in the GN build was throwing errors about these issues. --- atom/browser/api/frame_subscriber.cc | 2 +- atom/browser/api/frame_subscriber.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/api/frame_subscriber.cc b/atom/browser/api/frame_subscriber.cc index 5c49e688976a..dfa1523b2176 100644 --- a/atom/browser/api/frame_subscriber.cc +++ b/atom/browser/api/frame_subscriber.cc @@ -82,7 +82,7 @@ void FrameSubscriber::Done(const gfx::Rect& damage, const SkBitmap& frame) { : frame; size_t rgb_row_size = bitmap.width() * bitmap.bytesPerPixel(); - auto source = static_cast(bitmap.getPixels()); + auto* source = static_cast(bitmap.getPixels()); v8::MaybeLocal buffer = node::Buffer::Copy(isolate_, source, rgb_row_size * bitmap.height()); diff --git a/atom/browser/api/frame_subscriber.h b/atom/browser/api/frame_subscriber.h index 390b54f58cc9..058ba89ae203 100644 --- a/atom/browser/api/frame_subscriber.h +++ b/atom/browser/api/frame_subscriber.h @@ -28,7 +28,7 @@ class FrameSubscriber : public content::WebContentsObserver { content::WebContents* web_contents, const FrameCaptureCallback& callback, bool only_dirty); - ~FrameSubscriber(); + ~FrameSubscriber() override; private: gfx::Rect GetDamageRect();