mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Make our Windows build settings actually take effect

Browse source 
We need to put them inside the target_defaults dictionary. Now that these
settings are turned on, we need to ignore some warnings that Chromium ignores.
This commit is contained in:
Adam Roben 2013-05-28 11:56:17 -04:00
parent 37d847c416
commit 3f40456161
1 changed files with 23 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
brightray/brightray.gypi
View file

@ -169,18 +169,30 @@
'WIN32_LEAN_AND_MEAN', 'WIN32_LEAN_AND_MEAN',
'_ATL_NO_OPENGL', '_ATL_NO_OPENGL',
], ],
}, 'msvs_settings': {
'msvs_settings': { 'VCCLCompilerTool': {
'VCCLCompilerTool': { 'AdditionalOptions': ['/MP'],
'AdditionalOptions': ['/MP'], 'MinimalRebuild': 'false',
'MinimalRebuild': 'false', 'BufferSecurityCheck': 'true',
'BufferSecurityCheck': 'true', 'EnableFunctionLevelLinking': 'true',
'EnableFunctionLevelLinking': 'true', 'RuntimeTypeInfo': 'false',
'RuntimeTypeInfo': 'false', 'WarningLevel': '4',
'WarningLevel': '4', 'WarnAsError': 'true',
'WarnAsError': 'true', 'DebugInformationFormat': '3',
'DebugInformationFormat': '3', },
}, },
'msvs_disabled_warnings': [
4100, # unreferenced formal parameter
4127, # conditional expression is constant
4244, # 'initializing' : conversion from 'double' to 'size_t', possible loss of data
4245, # 'initializing' : conversion from 'int' to 'const net::QuicVersionTag', signed/unsigned mismatch
4251, # class 'std::xx' needs to have dll-interface.
4310, # cast truncates constant value
4480, # nonstandard extension used: specifying underlying type for enum
4481, # nonstandard extension used: override specifier 'override'
4512, # assignment operator could not be generated
4702, # unreachable code
],
}, },
}], }],
], ],