mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (#43804)

Browse source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-09-19 22:11:48 -05:00 • committed by GitHub
parent 78ede09ecd
commit 3ee3844bdb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/browser/notifications/win/notification_presenter_win.cc
View file

@ -43,17 +43,17 @@ bool SaveIconToPath(const SkBitmap& bitmap, const base::FilePath& path) {
} // namespace
// static
NotificationPresenter* NotificationPresenter::Create() {
std::unique_ptr<NotificationPresenter> NotificationPresenter::Create() {
if (!WindowsToastNotification::Initialize())
return nullptr;
return {};
auto presenter = std::make_unique<NotificationPresenterWin>();
if (!presenter->Init())
return nullptr;
return {};
if (IsDebuggingNotifications())
LOG(INFO) << "Successfully created Windows notifications presenter";
return presenter.release();
return presenter;
}
NotificationPresenterWin::NotificationPresenterWin() = default;