mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #27 from electron/fix-to-details-string-call

Browse source 
Fix Value::ToDetailString() call
This commit is contained in:
Charles Kerr 2018-04-13 11:19:17 -05:00 committed by GitHub
commit 3edb1eed8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
native_mate/arguments.cc
View file

@ -14,7 +14,8 @@ namespace {
std::string V8TypeAsString(v8::Isolate* isolate, v8::Local<v8::Value> value) { std::string V8TypeAsString(v8::Isolate* isolate, v8::Local<v8::Value> value) {
if (value.IsEmpty()) if (value.IsEmpty())
return "<empty handle>"; return "<empty handle>";
v8::MaybeLocal<v8::String> details = value->ToDetailString(isolate); v8::MaybeLocal<v8::String> details =
value->ToDetailString(isolate->GetCurrentContext());
std::string result; std::string result;
if (!details.IsEmpty()) if (!details.IsEmpty())
ConvertFromV8(isolate, details.ToLocalChecked(), &result); ConvertFromV8(isolate, details.ToLocalChecked(), &result);