From 3eab549369e1eeb758fb5c2b8a5f55fab2e4965d Mon Sep 17 00:00:00 2001 From: Nilay Arya <84241885+nilayarya@users.noreply.github.com> Date: Sat, 22 Feb 2025 21:45:36 +0530 Subject: [PATCH] docs: added upstream doc links for node, chromium, and v8 in default_app (#45392) --- default_app/preload.ts | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/default_app/preload.ts b/default_app/preload.ts index aa8c79ea11cc..fb6b9d4eaafb 100644 --- a/default_app/preload.ts +++ b/default_app/preload.ts @@ -34,18 +34,25 @@ async function loadSVG (element: HTMLSpanElement) { async function initialize () { const electronPath = await ipcRenderer.invoke('bootstrap'); - - function replaceText (selector: string, text: string) { + function replaceText (selector: string, text: string, link?: string) { const element = document.querySelector(selector); if (element) { - element.innerText = text; + if (link) { + const anchor = document.createElement('a'); + anchor.textContent = text; + anchor.href = link; + anchor.target = '_blank'; + element.appendChild(anchor); + } else { + element.innerText = text; + } } } - replaceText('.electron-version', `Electron v${process.versions.electron}`); - replaceText('.chrome-version', `Chromium v${process.versions.chrome}`); - replaceText('.node-version', `Node v${process.versions.node}`); - replaceText('.v8-version', `v8 v${process.versions.v8}`); + replaceText('.electron-version', `Electron v${process.versions.electron}`, 'https://electronjs.org/docs'); + replaceText('.chrome-version', `Chromium v${process.versions.chrome}`, 'https://developer.chrome.com/docs/chromium'); + replaceText('.node-version', `Node v${process.versions.node}`, `https://nodejs.org/docs/v${process.versions.node}/api`); + replaceText('.v8-version', `v8 v${process.versions.v8}`, 'https://v8.dev/docs'); replaceText('.command-example', `${electronPath} path-to-app`); for (const element of document.querySelectorAll('.octicon')) {