From 3e7a0e4b43551c644f570a088a3f23dbfbb19cf3 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Tue, 30 Aug 2016 09:27:12 -0700 Subject: [PATCH] Test external value as send argument --- spec/api-ipc-spec.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/spec/api-ipc-spec.js b/spec/api-ipc-spec.js index 6fe3ed5fccf8..57f556fa8f55 100644 --- a/spec/api-ipc-spec.js +++ b/spec/api-ipc-spec.js @@ -338,13 +338,16 @@ describe('ipc module', function () { it('does not crash on external objects (regression)', function (done) { const request = http.request({port: 5000, hostname: '127.0.0.1', method: 'GET', path: '/'}) + const stream = request.agent.sockets['127.0.0.1:5000:'][0]._handle._externalStream request.on('error', function () {}) - ipcRenderer.once('message', function (event, value) { - assert.equal(value.method, 'GET') - assert.equal(value.path, '/') + ipcRenderer.once('message', function (event, requestValue, externalStreamValue) { + assert.equal(requestValue.method, 'GET') + assert.equal(requestValue.path, '/') + assert.equal(externalStreamValue, null) done() }) - ipcRenderer.send('message', request) + + ipcRenderer.send('message', request, stream) }) it('can send objects that both reference the same object', function (done) {