From 3e5cabde39369dde07bbe7cc276167f7d82e9129 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Wed, 12 Mar 2025 23:20:55 -0500 Subject: [PATCH] refactor: use private inheritance from `mojo::MessageReceiver` (#45996) * refactor: make UtilityProcessWrapper inherit privately from mojo::MessageReceiver Co-authored-by: Charles Kerr * refactor: make ParentPort inherit privately from mojo::MessageReceiver Co-authored-by: Charles Kerr * refactor: make MessagePort inherit privately from mojo::MessageReceiver Co-authored-by: Charles Kerr --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_utility_process.h | 2 +- shell/browser/api/message_port.h | 2 +- shell/services/node/parent_port.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/shell/browser/api/electron_api_utility_process.h b/shell/browser/api/electron_api_utility_process.h index c7fb48b0dde7..6b1be4da2534 100644 --- a/shell/browser/api/electron_api_utility_process.h +++ b/shell/browser/api/electron_api_utility_process.h @@ -43,7 +43,7 @@ class UtilityProcessWrapper final : public gin::Wrappable, public gin_helper::Pinnable, public gin_helper::EventEmitterMixin, - public mojo::MessageReceiver, + private mojo::MessageReceiver, public node::mojom::NodeServiceClient, public content::ServiceProcessHost::Observer { public: diff --git a/shell/browser/api/message_port.h b/shell/browser/api/message_port.h index e46be76cbebb..ac598bf34a94 100644 --- a/shell/browser/api/message_port.h +++ b/shell/browser/api/message_port.h @@ -29,7 +29,7 @@ namespace electron { // A non-blink version of blink::MessagePort. class MessagePort final : public gin::Wrappable, public gin_helper::CleanedUpAtExit, - public mojo::MessageReceiver { + private mojo::MessageReceiver { public: ~MessagePort() override; static gin::Handle Create(v8::Isolate* isolate); diff --git a/shell/services/node/parent_port.h b/shell/services/node/parent_port.h index 20f6adc5b134..b39d825c7521 100644 --- a/shell/services/node/parent_port.h +++ b/shell/services/node/parent_port.h @@ -31,7 +31,7 @@ namespace electron { // for the lifetime of a Utility Process which // also means that GC lifecycle is ignored by this class. class ParentPort final : public gin::Wrappable, - public mojo::MessageReceiver { + private mojo::MessageReceiver { public: static ParentPort* GetInstance(); static gin::Handle Create(v8::Isolate* isolate);