From 3e2aa2f443b9c13bcaa36af7d245698f4bff9f26 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 25 Mar 2025 22:01:02 -0400 Subject: [PATCH] perf: avoid redundant map lookup in `WebFrameMain` constructor (#46276) perf: avoid double map lookup in WebFrameMain constructor Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_web_frame_main.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shell/browser/api/electron_api_web_frame_main.cc b/shell/browser/api/electron_api_web_frame_main.cc index 2cc7a1b47c0f..c81a2cb128f9 100644 --- a/shell/browser/api/electron_api_web_frame_main.cc +++ b/shell/browser/api/electron_api_web_frame_main.cc @@ -155,8 +155,8 @@ WebFrameMain::WebFrameMain(content::RenderFrameHost* rfh) if (!render_frame_detached_) GetFrameTreeNodeIdMap().emplace(frame_tree_node_id_, this); - DCHECK(!GetFrameTokenMap().contains(frame_token_)); - GetFrameTokenMap().emplace(frame_token_, this); + const auto [_, inserted] = GetFrameTokenMap().emplace(frame_token_, this); + DCHECK(inserted); // WebFrameMain should only be created for active or unloading frames. DCHECK(GetLifecycleState(rfh) == LifecycleState::kActive ||