mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: enable check raw ptr fields (#38167)

Browse source
This commit is contained in:
John Kleinschmidt 2023-05-11 16:07:39 -04:00 • committed by GitHub
parent 141175c723
commit 3dbc0a365f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
120 changed files with 298 additions and 185 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/browser/net/network_context_service.h
View file

@ -6,6 +6,7 @@
#define ELECTRON_SHELL_BROWSER_NET_NETWORK_CONTEXT_SERVICE_H_
#include "base/files/file_path.h"
#include "base/memory/raw_ptr.h"
#include "chrome/browser/net/proxy_config_monitor.h"
#include "components/keyed_service/core/keyed_service.h"
#include "mojo/public/cpp/bindings/remote.h"
@ -36,7 +37,7 @@ class NetworkContextService : public KeyedService {
bool in_memory,
const base::FilePath& path);
ElectronBrowserContext* browser_context_;
raw_ptr<ElectronBrowserContext> browser_context_;
ProxyConfigMonitor proxy_config_monitor_;
};

3
shell/browser/net/node_stream_loader.h
View file

@ -10,6 +10,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "mojo/public/cpp/bindings/remote.h"
@ -68,7 +69,7 @@ class NodeStreamLoader : public network::mojom::URLLoader {
mojo::Receiver<network::mojom::URLLoader> url_loader_;
mojo::Remote<network::mojom::URLLoaderClient> client_;
v8::Isolate* isolate_;
raw_ptr<v8::Isolate> isolate_;
v8::Global<v8::Object> emitter_;
v8::Global<v8::Value> buffer_;

7
shell/browser/net/proxying_url_loader_factory.h
View file

@ -12,6 +12,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/render_frame_host.h"
@ -131,7 +132,7 @@ class ProxyingURLLoaderFactory
void OnRequestError(const network::URLLoaderCompletionStatus& status);
void HandleBeforeRequestRedirect();
ProxyingURLLoaderFactory* const factory_;
raw_ptr<ProxyingURLLoaderFactory> const factory_;
network::ResourceRequest request_;
const absl::optional<url::Origin> original_initiator_;
const uint64_t request_id_ = 0;
@ -247,7 +248,7 @@ class ProxyingURLLoaderFactory
bool ShouldIgnoreConnectionsLimit(const network::ResourceRequest& request);
// Passed from api::WebRequest.
WebRequestAPI* web_request_api_;
raw_ptr<WebRequestAPI> web_request_api_;
// This is passed from api::Protocol.
//
@ -260,7 +261,7 @@ class ProxyingURLLoaderFactory
const int render_process_id_;
const int frame_routing_id_;
uint64_t* request_id_generator_; // managed by ElectronBrowserClient
raw_ptr<uint64_t> request_id_generator_; // managed by ElectronBrowserClient
std::unique_ptr<extensions::ExtensionNavigationUIData> navigation_ui_data_;
absl::optional<int64_t> navigation_id_;
mojo::ReceiverSet<network::mojom::URLLoaderFactory> proxy_receivers_;

3
shell/browser/net/proxying_websocket.h
View file

@ -9,6 +9,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "content/public/browser/content_browser_client.h"
#include "extensions/browser/api/web_request/web_request_info.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
@ -137,7 +138,7 @@ class ProxyingWebSocket : public network::mojom::WebSocketHandshakeClient,
void OnMojoConnectionError();
// Passed from api::WebRequest.
WebRequestAPI* web_request_api_;
raw_ptr<WebRequestAPI> web_request_api_;
// Saved to feed the api::WebRequest.
network::ResourceRequest request_;

3
shell/browser/net/resolve_host_function.h
View file

@ -9,6 +9,7 @@
#include <string>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "net/base/address_list.h"
@ -58,7 +59,7 @@ class ResolveHostFunction
mojo::Receiver<network::mojom::ResolveHostClient> receiver_{this};
// Weak Ref
ElectronBrowserContext* browser_context_;
raw_ptr<ElectronBrowserContext> browser_context_;
std::string host_;
network::mojom::ResolveHostParametersPtr params_;
ResolveHostCallback callback_;

3
shell/browser/net/resolve_proxy_helper.h
View file

@ -8,6 +8,7 @@
#include <deque>
#include <string>
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "services/network/public/mojom/proxy_lookup_client.mojom.h"
@ -70,7 +71,7 @@ class ResolveProxyHelper
mojo::Receiver<network::mojom::ProxyLookupClient> receiver_{this};
// Weak Ref
ElectronBrowserContext* browser_context_;
raw_ptr<ElectronBrowserContext> browser_context_;
};
} // namespace electron

3
shell/browser/net/system_network_context_manager.cc
View file

@ -10,6 +10,7 @@
#include <vector>
#include "base/command_line.h"
#include "base/memory/raw_ptr.h"
#include "base/path_service.h"
#include "base/strings/string_split.h"
#include "chrome/browser/browser_process.h"
@ -141,7 +142,7 @@ class SystemNetworkContextManager::URLLoaderFactoryForSystem
~URLLoaderFactoryForSystem() override = default;
SEQUENCE_CHECKER(sequence_checker_);
SystemNetworkContextManager* manager_;
raw_ptr<SystemNetworkContextManager> manager_;
};
network::mojom::NetworkContext* SystemNetworkContextManager::GetContext() {