mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use for-of instead of for simple array iteration (#39338)

Browse source
This commit is contained in:
Milan Burda 2023-08-07 11:30:15 +02:00 • committed by GitHub
parent 67523a47b4
commit 3d45429667
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

20
spec/lib/video-helpers.js
View file

@ -313,16 +313,16 @@ function bitsToBuffer (bits) {
function generateEBML (json) {
const ebml = [];
for (let i = 0; i < json.length; i++) {
if (!('id' in json[i])) {
for (const item of json) {
if (!('id' in item)) {
// already encoded blob or byteArray
ebml.push(json[i]);
ebml.push(item);
continue;
}
let data = json[i].data;
let data = item.data;
if (typeof data === 'object') data = generateEBML(data);
if (typeof data === 'number') data = ('size' in json[i]) ? numToFixedBuffer(data, json[i].size) : bitsToBuffer(data.toString(2));
if (typeof data === 'number') data = ('size' in item) ? numToFixedBuffer(data, item.size) : bitsToBuffer(data.toString(2));
if (typeof data === 'string') data = strToBuffer(data);
const len = data.size || data.byteLength || data.length;
@ -335,7 +335,7 @@ function generateEBML (json) {
// going to fix this, i'm probably just going to write some hacky thing which
// converts that string into a buffer-esque thing
ebml.push(numToBuffer(json[i].id));
ebml.push(numToBuffer(item.id));
ebml.push(bitsToBuffer(size));
ebml.push(data);
}
@ -349,13 +349,13 @@ function toFlatArray (arr, outBuffer) {
if (outBuffer == null) {
outBuffer = [];
}
for (let i = 0; i < arr.length; i++) {
if (typeof arr[i] === 'object') {
for (const item of arr) {
if (typeof item === 'object') {
// an array
toFlatArray(arr[i], outBuffer);
toFlatArray(item, outBuffer);
} else {
// a simple element
outBuffer.push(arr[i]);
outBuffer.push(item);
}
}
return outBuffer;