fix: modernize-avoid-c-arrays (#44813)
use string_view for constants used in methods that take string_view args
This commit is contained in:
parent
024fee4e44
commit
3c941c7e8f
11 changed files with 69 additions and 62 deletions
|
@ -6,6 +6,7 @@
|
|||
|
||||
#include <memory>
|
||||
#include <string>
|
||||
#include <string_view>
|
||||
#include <utility>
|
||||
|
||||
#include "base/memory/ref_counted_memory.h"
|
||||
|
@ -97,7 +98,7 @@ void ThemeDataSource::StartDataRequest(
|
|||
|
||||
// kColorsCssPath should stay consistent with COLORS_CSS_SELECTOR in
|
||||
// colors_css_updater.js.
|
||||
constexpr char kColorsCssPath[] = "colors.css";
|
||||
constexpr std::string_view kColorsCssPath = "colors.css";
|
||||
if (parsed_path == kColorsCssPath) {
|
||||
SendColorsCss(url, wc_getter, std::move(callback));
|
||||
return;
|
||||
|
|
|
@ -70,25 +70,26 @@ namespace electron {
|
|||
|
||||
namespace {
|
||||
|
||||
const char kChromeUIDevToolsURL[] =
|
||||
constexpr std::string_view kChromeUIDevToolsURL =
|
||||
"devtools://devtools/bundled/devtools_app.html?"
|
||||
"remoteBase=%s&"
|
||||
"can_dock=%s&"
|
||||
"toolbarColor=rgba(223,223,223,1)&"
|
||||
"textColor=rgba(0,0,0,1)&"
|
||||
"experiments=true";
|
||||
const char kChromeUIDevToolsRemoteFrontendBase[] =
|
||||
constexpr std::string_view kChromeUIDevToolsRemoteFrontendBase =
|
||||
"https://chrome-devtools-frontend.appspot.com/";
|
||||
const char kChromeUIDevToolsRemoteFrontendPath[] = "serve_file";
|
||||
constexpr std::string_view kChromeUIDevToolsRemoteFrontendPath = "serve_file";
|
||||
|
||||
const char kDevToolsBoundsPref[] = "electron.devtools.bounds";
|
||||
const char kDevToolsZoomPref[] = "electron.devtools.zoom";
|
||||
const char kDevToolsPreferences[] = "electron.devtools.preferences";
|
||||
constexpr std::string_view kDevToolsBoundsPref = "electron.devtools.bounds";
|
||||
constexpr std::string_view kDevToolsZoomPref = "electron.devtools.zoom";
|
||||
constexpr std::string_view kDevToolsPreferences =
|
||||
"electron.devtools.preferences";
|
||||
|
||||
const char kFrontendHostId[] = "id";
|
||||
const char kFrontendHostMethod[] = "method";
|
||||
const char kFrontendHostParams[] = "params";
|
||||
const char kTitleFormat[] = "Developer Tools - %s";
|
||||
constexpr std::string_view kFrontendHostId = "id";
|
||||
constexpr std::string_view kFrontendHostMethod = "method";
|
||||
constexpr std::string_view kFrontendHostParams = "params";
|
||||
constexpr std::string_view kTitleFormat = "Developer Tools - %s";
|
||||
|
||||
const size_t kMaxMessageChunkSize = IPC::Channel::kMaximumMessageSize / 4;
|
||||
|
||||
|
|
|
@ -6,6 +6,7 @@
|
|||
|
||||
#include <memory>
|
||||
#include <string>
|
||||
#include <string_view>
|
||||
#include <utility>
|
||||
#include <vector>
|
||||
|
||||
|
@ -50,49 +51,49 @@
|
|||
|
||||
namespace {
|
||||
|
||||
static const char kTargetsDataFile[] = "targets-data.json";
|
||||
constexpr std::string_view kTargetsDataFile = "targets-data.json";
|
||||
|
||||
static const char kAccessibilityModeField[] = "a11yMode";
|
||||
static const char kBrowsersField[] = "browsers";
|
||||
static const char kErrorField[] = "error";
|
||||
static const char kFaviconUrlField[] = "faviconUrl";
|
||||
static const char kNameField[] = "name";
|
||||
static const char kPagesField[] = "pages";
|
||||
static const char kPidField[] = "pid";
|
||||
static const char kProcessIdField[] = "processId";
|
||||
static const char kRequestTypeField[] = "requestType";
|
||||
static const char kRoutingIdField[] = "routingId";
|
||||
static const char kSessionIdField[] = "sessionId";
|
||||
static const char kSupportedApiTypesField[] = "supportedApiTypes";
|
||||
static const char kTreeField[] = "tree";
|
||||
static const char kTypeField[] = "type";
|
||||
static const char kUrlField[] = "url";
|
||||
static const char kWidgetsField[] = "widgets";
|
||||
static const char kApiTypeField[] = "apiType";
|
||||
constexpr std::string_view kAccessibilityModeField = "a11yMode";
|
||||
constexpr std::string_view kBrowsersField = "browsers";
|
||||
constexpr std::string_view kErrorField = "error";
|
||||
constexpr std::string_view kFaviconUrlField = "faviconUrl";
|
||||
constexpr std::string_view kNameField = "name";
|
||||
constexpr std::string_view kPagesField = "pages";
|
||||
constexpr std::string_view kPidField = "pid";
|
||||
constexpr std::string_view kProcessIdField = "processId";
|
||||
constexpr std::string_view kRequestTypeField = "requestType";
|
||||
constexpr std::string_view kRoutingIdField = "routingId";
|
||||
constexpr std::string_view kSessionIdField = "sessionId";
|
||||
constexpr std::string_view kSupportedApiTypesField = "supportedApiTypes";
|
||||
constexpr std::string_view kTreeField = "tree";
|
||||
constexpr std::string_view kTypeField = "type";
|
||||
constexpr std::string_view kUrlField = "url";
|
||||
constexpr std::string_view kWidgetsField = "widgets";
|
||||
constexpr std::string_view kApiTypeField = "apiType";
|
||||
|
||||
#if defined(USE_AURA)
|
||||
static const char kWidgetIdField[] = "widgetId";
|
||||
static const char kWidget[] = "widget";
|
||||
constexpr std::string_view kWidgetIdField = "widgetId";
|
||||
constexpr std::string_view kWidget = "widget";
|
||||
#endif
|
||||
|
||||
// Global flags
|
||||
static const char kBrowser[] = "browser";
|
||||
static const char kCopyTree[] = "copyTree";
|
||||
static const char kHTML[] = "html";
|
||||
static const char kLocked[] = "locked";
|
||||
static const char kNative[] = "native";
|
||||
static const char kPage[] = "page";
|
||||
static const char kPDFPrinting[] = "pdfPrinting";
|
||||
static const char kScreenReader[] = "screenreader";
|
||||
static const char kShowOrRefreshTree[] = "showOrRefreshTree";
|
||||
static const char kText[] = "text";
|
||||
static const char kViewsAccessibility[] = "viewsAccessibility";
|
||||
static const char kWeb[] = "web";
|
||||
constexpr std::string_view kBrowser = "browser";
|
||||
constexpr std::string_view kCopyTree = "copyTree";
|
||||
constexpr std::string_view kHTML = "html";
|
||||
constexpr std::string_view kLocked = "locked";
|
||||
constexpr std::string_view kNative = "native";
|
||||
constexpr std::string_view kPage = "page";
|
||||
constexpr std::string_view kPDFPrinting = "pdfPrinting";
|
||||
constexpr std::string_view kScreenReader = "screenreader";
|
||||
constexpr std::string_view kShowOrRefreshTree = "showOrRefreshTree";
|
||||
constexpr std::string_view kText = "text";
|
||||
constexpr std::string_view kViewsAccessibility = "viewsAccessibility";
|
||||
constexpr std::string_view kWeb = "web";
|
||||
|
||||
// Possible global flag values
|
||||
static const char kDisabled[] = "disabled";
|
||||
static const char kOff[] = "off";
|
||||
static const char kOn[] = "on";
|
||||
constexpr std::string_view kDisabled = "disabled";
|
||||
constexpr std::string_view kOff = "off";
|
||||
constexpr std::string_view kOn = "on";
|
||||
|
||||
base::Value::Dict BuildTargetDescriptor(
|
||||
const GURL& url,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue