mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: View reordering on re-addition to same parent (#42085)

Browse source
This commit is contained in:
Shelley Vohr 2024-05-10 10:16:33 +02:00 • committed by GitHub
parent e2acdffe58
commit 3bd807b03e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 87 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

32
spec/api-view-spec.ts
View file

@ -22,4 +22,36 @@ describe('View', () => {
w.contentView.addChildView(w.contentView);
}).to.throw('A view cannot be added as its own child');
});
it('does not crash when attempting to add a child multiple times', () => {
w = new BaseWindow({ show: false });
const cv = new View();
w.setContentView(cv);
const v = new View();
w.contentView.addChildView(v);
w.contentView.addChildView(v);
w.contentView.addChildView(v);
expect(w.contentView.children).to.have.lengthOf(1);
});
it('correctly reorders children', () => {
w = new BaseWindow({ show: false });
const cv = new View();
w.setContentView(cv);
const v1 = new View();
const v2 = new View();
const v3 = new View();
w.contentView.addChildView(v1);
w.contentView.addChildView(v2);
w.contentView.addChildView(v3);
expect(w.contentView.children).to.deep.equal([v1, v2, v3]);
w.contentView.addChildView(v1);
w.contentView.addChildView(v2);
expect(w.contentView.children).to.deep.equal([v3, v1, v2]);
});
});