mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

add new method and mark setExtraParameter for deprecation

Browse source
This commit is contained in:
Shelley Vohr 2017-11-01 21:57:43 -04:00
parent 33092e6324
commit 3af83f1c97
No known key found for this signature in database
GPG key ID: F13993A75599653C
8 changed files with 72 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

45
spec/api-crash-reporter-spec.js
View file

@ -11,7 +11,7 @@ const {closeWindow} = require('./window-helpers')
const {remote} = require('electron')
const {app, BrowserWindow, crashReporter} = remote.require('electron')
describe('crashReporter module', () => {
describe.only('crashReporter module', () => {
if (process.mas || process.env.DISABLE_CRASH_REPORTER_TESTS) return
let originalTempDirectory = null
@ -328,7 +328,8 @@ describe('crashReporter module', () => {
const parameters = crashReporter.getParameters()
assert(typeof parameters === 'object')
})
it('adds a parameter', () => {
// TODO(2.0) deprecate
it('adds a parameter with setExtraParameter', () => {
// only run on MacOS
if (process.platform !== 'darwin') return
@ -338,11 +339,22 @@ describe('crashReporter module', () => {
})
crashReporter.setExtraParameter('hello', 'world')
const updatedParams = crashReporter.getParameters()
assert('hello' in updatedParams)
assert('hello' in crashReporter.getParameters())
})
it('removes a parameter', () => {
it('adds a parameter with addExtraParameter', () => {
// only run on MacOS
if (process.platform !== 'darwin') return
crashReporter.start({
companyName: 'Umbrella Corporation',
submitURL: 'http://127.0.0.1/crashes'
})
crashReporter.addExtraParameter('hello', 'world')
assert('hello' in crashReporter.getParameters())
})
// TODO(2.0) deprecate
it('removes a parameter with setExtraParameter', () => {
// only run on MacOS
if (process.platform !== 'darwin') return
@ -352,12 +364,25 @@ describe('crashReporter module', () => {
})
crashReporter.setExtraParameter('hello', 'world')
const originalParams = crashReporter.getParameters()
assert('hello' in originalParams)
assert('hello' in crashReporter.getParameters())
crashReporter.setExtraParameter('hello')
assert(!('hello' in crashReporter.getParameters()))
})
it('removes a parameter with removeExtraParameter', () => {
// only run on MacOS
if (process.platform !== 'darwin') return
crashReporter.start({
companyName: 'Umbrella Corporation',
submitURL: 'http://127.0.0.1/crashes'
})
crashReporter.setExtraParameter('hello', 'world')
assert('hello' in crashReporter.getParameters())
crashReporter.removeExtraParameter('hello')
const updatedParams = crashReporter.getParameters()
assert(!('hello' in updatedParams))
assert(!('hello' in crashReporter.getParameters()))
})
})
})