refactor: add prefer-const to .eslintrc + fix errors (#14880)

lib/renderer/api/remote.js

@@ -36,7 +36,7 @@ function wrapArgs (args, visited = new Set()) {
 
     if (Array.isArray(value)) {
       visited.add(value)
-      let meta = {
+      const meta = {
         type: 'array',
         value: wrapArgs(value, visited)
       }
@@ -67,13 +67,13 @@ function wrapArgs (args, visited = new Set()) {
         }
       }
 
-      let meta = {
+      const meta = {
         type: 'object',
         name: value.constructor ? value.constructor.name : '',
         members: []
       }
       visited.add(value)
-      for (let prop in value) {
+      for (const prop in value) {
         meta.members.push({
           name: prop,
           value: valueToMeta(value[prop])
@@ -109,10 +109,10 @@ function wrapArgs (args, visited = new Set()) {
 function setObjectMembers (ref, object, metaId, members) {
   if (!Array.isArray(members)) return
 
-  for (let member of members) {
+  for (const member of members) {
     if (object.hasOwnProperty(member.name)) continue
 
-    let descriptor = { enumerable: member.enumerable }
+    const descriptor = { enumerable: member.enumerable }
     if (member.type === 'method') {
       const remoteMemberFunction = function (...args) {
         let command
@@ -163,7 +163,7 @@ function setObjectMembers (ref, object, metaId, members) {
 // This matches |getObjectPrototype| in rpc-server.
 function setObjectPrototype (ref, object, metaId, descriptor) {
   if (descriptor === null) return
-  let proto = {}
+  const proto = {}
   setObjectMembers(ref, proto, metaId, descriptor.members)
   setObjectPrototype(ref, proto, metaId, descriptor.proto)
   Object.setPrototypeOf(object, proto)
@@ -201,7 +201,7 @@ function proxyFunctionProperties (remoteMemberFunction, metaId, name) {
       return Object.getOwnPropertyNames(target)
     },
     getOwnPropertyDescriptor: (target, property) => {
-      let descriptor = Object.getOwnPropertyDescriptor(target, property)
+      const descriptor = Object.getOwnPropertyDescriptor(target, property)
       if (descriptor) return descriptor
       loadRemoteProperties()
       return Object.getOwnPropertyDescriptor(target, property)
@@ -231,7 +231,7 @@ function metaToValue (meta) {
 
     // A shadow class to represent the remote function object.
     if (meta.type === 'function') {
-      let remoteFunction = function (...args) {
+      const remoteFunction = function (...args) {
         let command
         if (this && this.constructor === remoteFunction) {
           command = 'ELECTRON_BROWSER_CONSTRUCTOR'
@@ -262,7 +262,7 @@ function metaToValue (meta) {
 function metaToPlainObject (meta) {
   const obj = (() => meta.type === 'error' ? new Error() : {})()
   for (let i = 0; i < meta.members.length; i++) {
-    let { name, value } = meta.members[i]
+    const { name, value } = meta.members[i]
     obj[name] = value
   }
   return obj