From 3a58545a5915269e0d3d79f696634af518e3c78b Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 10 Jul 2018 08:01:26 -0700 Subject: [PATCH] chore: replace _ASSERT with DCHECK in toast.cc (#13598) _ASSERT was triggering errors about unused values when in debug mode --- brightray/browser/win/win32_desktop_notifications/toast.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/brightray/browser/win/win32_desktop_notifications/toast.cc b/brightray/browser/win/win32_desktop_notifications/toast.cc index ea8a5642c87e..061eb977a8dc 100644 --- a/brightray/browser/win/win32_desktop_notifications/toast.cc +++ b/brightray/browser/win/win32_desktop_notifications/toast.cc @@ -5,6 +5,7 @@ #include #include #include +#include "base/logging.h" #include "brightray/browser/win/win32_desktop_notifications/common.h" #pragma comment(lib, "msimg32.lib") @@ -566,7 +567,7 @@ void DesktopNotificationController::Toast::UpdateBufferSize() { auto b1 = UpdateLayeredWindowIndirect(hwnd_, &ulw); ulw.prcDirty = &dirty2; auto b2 = UpdateLayeredWindowIndirect(hwnd_, &ulw); - _ASSERT(b1 && b2); + DCHECK(b1 && b2); } return; @@ -745,14 +746,14 @@ HDWP DesktopNotificationController::Toast::Animate(HDWP hdwp, } void DesktopNotificationController::Toast::StartEaseIn() { - _ASSERT(!ease_in_active_); + DCHECK(!ease_in_active_); ease_in_start_ = GetTickCount(); ease_in_active_ = true; data_->controller->StartAnimation(); } void DesktopNotificationController::Toast::StartEaseOut() { - _ASSERT(!ease_out_active_); + DCHECK(!ease_out_active_); ease_out_start_ = GetTickCount(); ease_out_active_ = true; data_->controller->StartAnimation();