refactor: more constexpr lookup tables (#38886)

* refactor: use constexpr lookup table in electron_api_web_contents.cc

* refactor: make KeyboardCodeFromStr() private

it is only used as a helper to KeyboardCodeFromStr()

* chore: savepoint

* chore: make lint happy

* fixup! refactor: make KeyboardCodeFromStr() private

* refactor: use constexpr lookup table in electron_url_loader_factory

* refactor: use constexpr lookup table in electron_api_tray

* refactor: use constexpr lookup table in web_contents_preferences.cc

* refactor: use constexpr lookup table in content_converter
This commit is contained in:
Charles Kerr 2023-06-22 07:33:44 -05:00 committed by GitHub
parent 1eb19f3078
commit 395b608dd5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 349 additions and 460 deletions

View file

@ -6,6 +6,7 @@
#include <string> #include <string>
#include "base/containers/fixed_flat_map.h"
#include "gin/dictionary.h" #include "gin/dictionary.h"
#include "gin/object_template_builder.h" #include "gin/object_template_builder.h"
#include "shell/browser/api/electron_api_menu.h" #include "shell/browser/api/electron_api_menu.h"
@ -29,27 +30,16 @@ struct Converter<electron::TrayIcon::IconType> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
electron::TrayIcon::IconType* out) { electron::TrayIcon::IconType* out) {
using IconType = electron::TrayIcon::IconType; using Val = electron::TrayIcon::IconType;
std::string mode; static constexpr auto Lookup =
if (ConvertFromV8(isolate, val, &mode)) { base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
if (mode == "none") { {"custom", Val::kCustom},
*out = IconType::kNone; {"error", Val::kError},
return true; {"info", Val::kInfo},
} else if (mode == "info") { {"none", Val::kNone},
*out = IconType::kInfo; {"warning", Val::kWarning},
return true; });
} else if (mode == "warning") { return FromV8WithLookup(isolate, val, Lookup, out);
*out = IconType::kWarning;
return true;
} else if (mode == "error") {
*out = IconType::kError;
return true;
} else if (mode == "custom") {
*out = IconType::kCustom;
return true;
}
}
return false;
} }
}; };

View file

@ -12,6 +12,7 @@
#include <vector> #include <vector>
#include "base/containers/contains.h" #include "base/containers/contains.h"
#include "base/containers/fixed_flat_map.h"
#include "base/containers/id_map.h" #include "base/containers/id_map.h"
#include "base/files/file_util.h" #include "base/files/file_util.h"
#include "base/json/json_reader.h" #include "base/json/json_reader.h"
@ -202,26 +203,15 @@ struct Converter<printing::mojom::MarginType> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
printing::mojom::MarginType* out) { printing::mojom::MarginType* out) {
std::string type; using Val = printing::mojom::MarginType;
if (ConvertFromV8(isolate, val, &type)) { static constexpr auto Lookup =
if (type == "default") { base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
*out = printing::mojom::MarginType::kDefaultMargins; {"custom", Val::kCustomMargins},
return true; {"default", Val::kDefaultMargins},
} {"none", Val::kNoMargins},
if (type == "none") { {"printableArea", Val::kPrintableAreaMargins},
*out = printing::mojom::MarginType::kNoMargins; });
return true; return FromV8WithLookup(isolate, val, Lookup, out);
}
if (type == "printableArea") {
*out = printing::mojom::MarginType::kPrintableAreaMargins;
return true;
}
if (type == "custom") {
*out = printing::mojom::MarginType::kCustomMargins;
return true;
}
}
return false;
} }
}; };
@ -230,22 +220,14 @@ struct Converter<printing::mojom::DuplexMode> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
printing::mojom::DuplexMode* out) { printing::mojom::DuplexMode* out) {
std::string mode; using Val = printing::mojom::DuplexMode;
if (ConvertFromV8(isolate, val, &mode)) { static constexpr auto Lookup =
if (mode == "simplex") { base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
*out = printing::mojom::DuplexMode::kSimplex; {"longEdge", Val::kLongEdge},
return true; {"shortEdge", Val::kShortEdge},
} {"simplex", Val::kSimplex},
if (mode == "longEdge") { });
*out = printing::mojom::DuplexMode::kLongEdge; return FromV8WithLookup(isolate, val, Lookup, out);
return true;
}
if (mode == "shortEdge") {
*out = printing::mojom::DuplexMode::kShortEdge;
return true;
}
}
return false;
} }
}; };
@ -285,20 +267,14 @@ struct Converter<content::SavePageType> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
content::SavePageType* out) { content::SavePageType* out) {
std::string save_type; using Val = content::SavePageType;
if (!ConvertFromV8(isolate, val, &save_type)) static constexpr auto Lookup =
return false; base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
save_type = base::ToLowerASCII(save_type); {"htmlcomplete", Val::SAVE_PAGE_TYPE_AS_COMPLETE_HTML},
if (save_type == "htmlonly") { {"htmlonly", Val::SAVE_PAGE_TYPE_AS_ONLY_HTML},
*out = content::SAVE_PAGE_TYPE_AS_ONLY_HTML; {"mhtml", Val::SAVE_PAGE_TYPE_AS_MHTML},
} else if (save_type == "htmlcomplete") { });
*out = content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML; return FromV8WithLowerLookup(isolate, val, Lookup, out);
} else if (save_type == "mhtml") {
*out = content::SAVE_PAGE_TYPE_AS_MHTML;
} else {
return false;
}
return true;
} }
}; };
@ -336,22 +312,15 @@ struct Converter<electron::api::WebContents::Type> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
electron::api::WebContents::Type* out) { electron::api::WebContents::Type* out) {
using Type = electron::api::WebContents::Type; using Val = electron::api::WebContents::Type;
std::string type; static constexpr auto Lookup =
if (!ConvertFromV8(isolate, val, &type)) base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
return false; {"backgroundPage", Val::kBackgroundPage},
if (type == "backgroundPage") { {"browserView", Val::kBrowserView},
*out = Type::kBackgroundPage; {"offscreen", Val::kOffScreen},
} else if (type == "browserView") { {"webview", Val::kWebView},
*out = Type::kBrowserView; });
} else if (type == "webview") { return FromV8WithLookup(isolate, val, Lookup, out);
*out = Type::kWebView;
} else if (type == "offscreen") {
*out = Type::kOffScreen;
} else {
return false;
}
return true;
} }
}; };

View file

@ -9,6 +9,7 @@
#include <string> #include <string>
#include <utility> #include <utility>
#include "base/containers/fixed_flat_map.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "base/uuid.h" #include "base/uuid.h"
@ -45,22 +46,17 @@ struct Converter<electron::ProtocolType> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
electron::ProtocolType* out) { electron::ProtocolType* out) {
std::string type; using Val = electron::ProtocolType;
if (!ConvertFromV8(isolate, val, &type)) static constexpr auto Lookup =
return false; base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
if (type == "buffer") // note "free" is internal type, not allowed to be passed from user
*out = electron::ProtocolType::kBuffer; {"buffer", Val::kBuffer},
else if (type == "string") {"file", Val::kFile},
*out = electron::ProtocolType::kString; {"http", Val::kHttp},
else if (type == "file") {"stream", Val::kStream},
*out = electron::ProtocolType::kFile; {"string", Val::kString},
else if (type == "http") });
*out = electron::ProtocolType::kHttp; return FromV8WithLookup(isolate, val, Lookup, out);
else if (type == "stream")
*out = electron::ProtocolType::kStream;
else // note "free" is internal type, not allowed to be passed from user
return false;
return true;
} }
}; };

View file

@ -10,6 +10,7 @@
#include <vector> #include <vector>
#include "base/command_line.h" #include "base/command_line.h"
#include "base/containers/fixed_flat_map.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
@ -43,20 +44,15 @@ struct Converter<blink::mojom::AutoplayPolicy> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
blink::mojom::AutoplayPolicy* out) { blink::mojom::AutoplayPolicy* out) {
std::string policy_str; using Val = blink::mojom::AutoplayPolicy;
if (!ConvertFromV8(isolate, val, &policy_str)) static constexpr auto Lookup =
return false; base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
if (policy_str == "no-user-gesture-required") { {"document-user-activation-required",
*out = blink::mojom::AutoplayPolicy::kNoUserGestureRequired; Val::kDocumentUserActivationRequired},
return true; {"no-user-gesture-required", Val::kNoUserGestureRequired},
} else if (policy_str == "user-gesture-required") { {"user-gesture-required", Val::kUserGestureRequired},
*out = blink::mojom::AutoplayPolicy::kUserGestureRequired; });
return true; return FromV8WithLookup(isolate, val, Lookup, out);
} else if (policy_str == "document-user-activation-required") {
*out = blink::mojom::AutoplayPolicy::kDocumentUserActivationRequired;
return true;
}
return false;
} }
}; };
@ -65,23 +61,15 @@ struct Converter<blink::mojom::V8CacheOptions> {
static bool FromV8(v8::Isolate* isolate, static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
blink::mojom::V8CacheOptions* out) { blink::mojom::V8CacheOptions* out) {
std::string v8_cache_options; using Val = blink::mojom::V8CacheOptions;
if (!ConvertFromV8(isolate, val, &v8_cache_options)) static constexpr auto Lookup =
return false; base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
if (v8_cache_options == "none") { {"bypassHeatCheck", Val::kCodeWithoutHeatCheck},
*out = blink::mojom::V8CacheOptions::kNone; {"bypassHeatCheckAndEagerCompile", Val::kFullCodeWithoutHeatCheck},
return true; {"code", Val::kCode},
} else if (v8_cache_options == "code") { {"none", Val::kNone},
*out = blink::mojom::V8CacheOptions::kCode; });
return true; return FromV8WithLookup(isolate, val, Lookup, out);
} else if (v8_cache_options == "bypassHeatCheck") {
*out = blink::mojom::V8CacheOptions::kCodeWithoutHeatCheck;
return true;
} else if (v8_cache_options == "bypassHeatCheckAndEagerCompile") {
*out = blink::mojom::V8CacheOptions::kFullCodeWithoutHeatCheck;
return true;
}
return false;
} }
}; };

View file

@ -6,6 +6,7 @@
#include <string> #include <string>
#include "base/containers/fixed_flat_map.h"
#include "content/public/browser/context_menu_params.h" #include "content/public/browser/context_menu_params.h"
#include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/native_web_keyboard_event.h"
#include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents.h"
@ -222,20 +223,14 @@ v8::Local<v8::Value> Converter<blink::PermissionType>::ToV8(
bool Converter<content::StopFindAction>::FromV8(v8::Isolate* isolate, bool Converter<content::StopFindAction>::FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val, v8::Local<v8::Value> val,
content::StopFindAction* out) { content::StopFindAction* out) {
std::string action; using Val = content::StopFindAction;
if (!ConvertFromV8(isolate, val, &action)) static constexpr auto Lookup =
return false; base::MakeFixedFlatMapSorted<base::StringPiece, Val>({
{"activateSelection", Val::STOP_FIND_ACTION_ACTIVATE_SELECTION},
if (action == "clearSelection") {"clearSelection", Val::STOP_FIND_ACTION_CLEAR_SELECTION},
*out = content::STOP_FIND_ACTION_CLEAR_SELECTION; {"keepSelection", Val::STOP_FIND_ACTION_KEEP_SELECTION},
else if (action == "keepSelection") });
*out = content::STOP_FIND_ACTION_KEEP_SELECTION; return FromV8WithLookup(isolate, val, Lookup, out);
else if (action == "activateSelection")
*out = content::STOP_FIND_ACTION_ACTIVATE_SELECTION;
else
return false;
return true;
} }
// static // static

View file

@ -4,6 +4,7 @@
#include <string> #include <string>
#include "base/containers/fixed_flat_map.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "shell/common/keyboard_util.h" #include "shell/common/keyboard_util.h"
@ -14,320 +15,275 @@ namespace electron {
namespace { namespace {
// Return key code represented by |str|. using CodeAndShiftedChar =
ui::KeyboardCode KeyboardCodeFromKeyIdentifier( std::pair<ui::KeyboardCode, absl::optional<char16_t>>;
const std::string& s,
absl::optional<char16_t>* shifted_char) { constexpr CodeAndShiftedChar KeyboardCodeFromKeyIdentifier(
std::string str = base::ToLowerASCII(s); base::StringPiece str) {
if (str == "ctrl" || str == "control") {
return ui::VKEY_CONTROL;
} else if (str == "super" || str == "cmd" || str == "command" ||
str == "meta") {
return ui::VKEY_COMMAND;
} else if (str == "commandorcontrol" || str == "cmdorctrl") {
#if BUILDFLAG(IS_MAC) #if BUILDFLAG(IS_MAC)
return ui::VKEY_COMMAND; constexpr auto CommandOrControl = ui::VKEY_COMMAND;
#else #else
return ui::VKEY_CONTROL; constexpr auto CommandOrControl = ui::VKEY_CONTROL;
#endif #endif
} else if (str == "alt" || str == "option") {
return ui::VKEY_MENU; constexpr auto Lookup =
} else if (str == "shift") { base::MakeFixedFlatMapSorted<base::StringPiece, CodeAndShiftedChar>({
return ui::VKEY_SHIFT; {"alt", {ui::VKEY_MENU, {}}},
} else if (str == "altgr") { {"altgr", {ui::VKEY_ALTGR, {}}},
return ui::VKEY_ALTGR; {"backspace", {ui::VKEY_BACK, {}}},
} else if (str == "plus") { {"capslock", {ui::VKEY_CAPITAL, {}}},
shifted_char->emplace('+'); {"cmd", {ui::VKEY_COMMAND, {}}},
return ui::VKEY_OEM_PLUS; {"cmdorctrl", {CommandOrControl, {}}},
} else if (str == "capslock") { {"command", {ui::VKEY_COMMAND, {}}},
return ui::VKEY_CAPITAL; {"commandorcontrol", {CommandOrControl, {}}},
} else if (str == "numlock") { {"control", {ui::VKEY_CONTROL, {}}},
return ui::VKEY_NUMLOCK; {"ctrl", {ui::VKEY_CONTROL, {}}},
} else if (str == "scrolllock") { {"delete", {ui::VKEY_DELETE, {}}},
return ui::VKEY_SCROLL; {"down", {ui::VKEY_DOWN, {}}},
} else if (str == "tab") { {"end", {ui::VKEY_END, {}}},
return ui::VKEY_TAB; {"enter", {ui::VKEY_RETURN, {}}},
} else if (str == "num0") { {"esc", {ui::VKEY_ESCAPE, {}}},
return ui::VKEY_NUMPAD0; {"escape", {ui::VKEY_ESCAPE, {}}},
} else if (str == "num1") { {"f1", {ui::VKEY_F1, {}}},
return ui::VKEY_NUMPAD1; {"f10", {ui::VKEY_F10, {}}},
} else if (str == "num2") { {"f11", {ui::VKEY_F11, {}}},
return ui::VKEY_NUMPAD2; {"f12", {ui::VKEY_F12, {}}},
} else if (str == "num3") { {"f13", {ui::VKEY_F13, {}}},
return ui::VKEY_NUMPAD3; {"f14", {ui::VKEY_F14, {}}},
} else if (str == "num4") { {"f15", {ui::VKEY_F15, {}}},
return ui::VKEY_NUMPAD4; {"f16", {ui::VKEY_F16, {}}},
} else if (str == "num5") { {"f17", {ui::VKEY_F17, {}}},
return ui::VKEY_NUMPAD5; {"f18", {ui::VKEY_F18, {}}},
} else if (str == "num6") { {"f19", {ui::VKEY_F19, {}}},
return ui::VKEY_NUMPAD6; {"f2", {ui::VKEY_F2, {}}},
} else if (str == "num7") { {"f20", {ui::VKEY_F20, {}}},
return ui::VKEY_NUMPAD7; {"f21", {ui::VKEY_F21, {}}},
} else if (str == "num8") { {"f22", {ui::VKEY_F22, {}}},
return ui::VKEY_NUMPAD8; {"f23", {ui::VKEY_F23, {}}},
} else if (str == "num9") { {"f24", {ui::VKEY_F24, {}}},
return ui::VKEY_NUMPAD9; {"f3", {ui::VKEY_F3, {}}},
} else if (str == "numadd") { {"f4", {ui::VKEY_F4, {}}},
return ui::VKEY_ADD; {"f5", {ui::VKEY_F5, {}}},
} else if (str == "nummult") { {"f6", {ui::VKEY_F6, {}}},
return ui::VKEY_MULTIPLY; {"f7", {ui::VKEY_F7, {}}},
} else if (str == "numdec") { {"f8", {ui::VKEY_F8, {}}},
return ui::VKEY_DECIMAL; {"f9", {ui::VKEY_F9, {}}},
} else if (str == "numsub") { {"home", {ui::VKEY_HOME, {}}},
return ui::VKEY_SUBTRACT; {"insert", {ui::VKEY_INSERT, {}}},
} else if (str == "numdiv") { {"left", {ui::VKEY_LEFT, {}}},
return ui::VKEY_DIVIDE; {"medianexttrack", {ui::VKEY_MEDIA_NEXT_TRACK, {}}},
} else if (str == "space") { {"mediaplaypause", {ui::VKEY_MEDIA_PLAY_PAUSE, {}}},
return ui::VKEY_SPACE; {"mediaprevioustrack", {ui::VKEY_MEDIA_PREV_TRACK, {}}},
} else if (str == "backspace") { {"mediastop", {ui::VKEY_MEDIA_STOP, {}}},
return ui::VKEY_BACK; {"meta", {ui::VKEY_COMMAND, {}}},
} else if (str == "delete") { {"num0", {ui::VKEY_NUMPAD0, {}}},
return ui::VKEY_DELETE; {"num1", {ui::VKEY_NUMPAD1, {}}},
} else if (str == "insert") { {"num2", {ui::VKEY_NUMPAD2, {}}},
return ui::VKEY_INSERT; {"num3", {ui::VKEY_NUMPAD3, {}}},
} else if (str == "enter" || str == "return") { {"num4", {ui::VKEY_NUMPAD4, {}}},
return ui::VKEY_RETURN; {"num5", {ui::VKEY_NUMPAD5, {}}},
} else if (str == "up") { {"num6", {ui::VKEY_NUMPAD6, {}}},
return ui::VKEY_UP; {"num7", {ui::VKEY_NUMPAD7, {}}},
} else if (str == "down") { {"num8", {ui::VKEY_NUMPAD8, {}}},
return ui::VKEY_DOWN; {"num9", {ui::VKEY_NUMPAD9, {}}},
} else if (str == "left") { {"numadd", {ui::VKEY_ADD, {}}},
return ui::VKEY_LEFT; {"numdec", {ui::VKEY_DECIMAL, {}}},
} else if (str == "right") { {"numdiv", {ui::VKEY_DIVIDE, {}}},
return ui::VKEY_RIGHT; {"numlock", {ui::VKEY_NUMLOCK, {}}},
} else if (str == "home") { {"nummult", {ui::VKEY_MULTIPLY, {}}},
return ui::VKEY_HOME; {"numsub", {ui::VKEY_SUBTRACT, {}}},
} else if (str == "end") { {"option", {ui::VKEY_MENU, {}}},
return ui::VKEY_END; {"pagedown", {ui::VKEY_NEXT, {}}},
} else if (str == "pageup") { {"pageup", {ui::VKEY_PRIOR, {}}},
return ui::VKEY_PRIOR; {"plus", {ui::VKEY_OEM_PLUS, '+'}},
} else if (str == "pagedown") { {"printscreen", {ui::VKEY_SNAPSHOT, {}}},
return ui::VKEY_NEXT; {"return", {ui::VKEY_RETURN, {}}},
} else if (str == "esc" || str == "escape") { {"right", {ui::VKEY_RIGHT, {}}},
return ui::VKEY_ESCAPE; {"scrolllock", {ui::VKEY_SCROLL, {}}},
} else if (str == "volumemute") { {"shift", {ui::VKEY_SHIFT, {}}},
return ui::VKEY_VOLUME_MUTE; {"space", {ui::VKEY_SPACE, {}}},
} else if (str == "volumeup") { {"super", {ui::VKEY_COMMAND, {}}},
return ui::VKEY_VOLUME_UP; {"tab", {ui::VKEY_TAB, {}}},
} else if (str == "volumedown") { {"up", {ui::VKEY_UP, {}}},
return ui::VKEY_VOLUME_DOWN; {"volumedown", {ui::VKEY_VOLUME_DOWN, {}}},
} else if (str == "medianexttrack") { {"volumemute", {ui::VKEY_VOLUME_MUTE, {}}},
return ui::VKEY_MEDIA_NEXT_TRACK; {"volumeup", {ui::VKEY_VOLUME_UP, {}}},
} else if (str == "mediaprevioustrack") { });
return ui::VKEY_MEDIA_PREV_TRACK;
} else if (str == "mediastop") { if (auto* const iter = Lookup.find(str); iter != Lookup.end())
return ui::VKEY_MEDIA_STOP; return iter->second;
} else if (str == "mediaplaypause") {
return ui::VKEY_MEDIA_PLAY_PAUSE; return {ui::VKEY_UNKNOWN, {}};
} else if (str == "printscreen") { }
return ui::VKEY_SNAPSHOT;
} else if (str.size() > 1 && str[0] == 'f') { constexpr CodeAndShiftedChar KeyboardCodeFromCharCode(char16_t c) {
// F1 - F24. switch (c) {
int n; case ' ':
if (base::StringToInt(str.c_str() + 1, &n) && n > 0 && n < 25) { return {ui::VKEY_SPACE, {}};
return static_cast<ui::KeyboardCode>(ui::VKEY_F1 + n - 1); case '!':
} else { return {ui::VKEY_1, '!'};
LOG(WARNING) << str << "is not available on keyboard"; case '"':
return ui::VKEY_UNKNOWN; return {ui::VKEY_OEM_7, '"'};
} case '#':
} else { return {ui::VKEY_3, '#'};
if (str.size() > 2) case '$':
LOG(WARNING) << "Invalid accelerator token: " << str; return {ui::VKEY_4, '$'};
return ui::VKEY_UNKNOWN; case '%':
return {ui::VKEY_5, '%'};
case '&':
return {ui::VKEY_7, '&'};
case '(':
return {ui::VKEY_9, '('};
case ')':
return {ui::VKEY_0, ')'};
case '*':
return {ui::VKEY_8, '*'};
case '+':
return {ui::VKEY_OEM_PLUS, '+'};
case ',':
return {ui::VKEY_OEM_COMMA, {}};
case '-':
return {ui::VKEY_OEM_MINUS, {}};
case '.':
return {ui::VKEY_OEM_PERIOD, {}};
case '/':
return {ui::VKEY_OEM_2, {}};
case '0':
return {ui::VKEY_0, {}};
case '1':
return {ui::VKEY_1, {}};
case '2':
return {ui::VKEY_2, {}};
case '3':
return {ui::VKEY_3, {}};
case '4':
return {ui::VKEY_4, {}};
case '5':
return {ui::VKEY_5, {}};
case '6':
return {ui::VKEY_6, {}};
case '7':
return {ui::VKEY_7, {}};
case '8':
return {ui::VKEY_8, {}};
case '9':
return {ui::VKEY_9, {}};
case ':':
return {ui::VKEY_OEM_1, ':'};
case ';':
return {ui::VKEY_OEM_1, {}};
case '<':
return {ui::VKEY_OEM_COMMA, '<'};
case '=':
return {ui::VKEY_OEM_PLUS, {}};
case '>':
return {ui::VKEY_OEM_PERIOD, '>'};
case '?':
return {ui::VKEY_OEM_2, '?'};
case '@':
return {ui::VKEY_2, '@'};
case '[':
return {ui::VKEY_OEM_4, {}};
case '\'':
return {ui::VKEY_OEM_7, {}};
case '\\':
return {ui::VKEY_OEM_5, {}};
case ']':
return {ui::VKEY_OEM_6, {}};
case '^':
return {ui::VKEY_6, '^'};
case '_':
return {ui::VKEY_OEM_MINUS, '_'};
case '`':
return {ui::VKEY_OEM_3, {}};
case 'a':
return {ui::VKEY_A, {}};
case 'b':
return {ui::VKEY_B, {}};
case 'c':
return {ui::VKEY_C, {}};
case 'd':
return {ui::VKEY_D, {}};
case 'e':
return {ui::VKEY_E, {}};
case 'f':
return {ui::VKEY_F, {}};
case 'g':
return {ui::VKEY_G, {}};
case 'h':
return {ui::VKEY_H, {}};
case 'i':
return {ui::VKEY_I, {}};
case 'j':
return {ui::VKEY_J, {}};
case 'k':
return {ui::VKEY_K, {}};
case 'l':
return {ui::VKEY_L, {}};
case 'm':
return {ui::VKEY_M, {}};
case 'n':
return {ui::VKEY_N, {}};
case 'o':
return {ui::VKEY_O, {}};
case 'p':
return {ui::VKEY_P, {}};
case 'q':
return {ui::VKEY_Q, {}};
case 'r':
return {ui::VKEY_R, {}};
case 's':
return {ui::VKEY_S, {}};
case 't':
return {ui::VKEY_T, {}};
case 'u':
return {ui::VKEY_U, {}};
case 'v':
return {ui::VKEY_V, {}};
case 'w':
return {ui::VKEY_W, {}};
case 'x':
return {ui::VKEY_X, {}};
case 'y':
return {ui::VKEY_Y, {}};
case 'z':
return {ui::VKEY_Z, {}};
case '{':
return {ui::VKEY_OEM_4, '{'};
case '|':
return {ui::VKEY_OEM_5, '|'};
case '}':
return {ui::VKEY_OEM_6, '}'};
case '~':
return {ui::VKEY_OEM_3, '~'};
case 0x08:
return {ui::VKEY_BACK, {}};
case 0x09:
return {ui::VKEY_TAB, {}};
case 0x0D:
return {ui::VKEY_RETURN, {}};
case 0x1B:
return {ui::VKEY_ESCAPE, {}};
case 0x7F:
return {ui::VKEY_DELETE, {}};
default:
return {ui::VKEY_UNKNOWN, {}};
} }
} }
} // namespace } // namespace
ui::KeyboardCode KeyboardCodeFromCharCode(char16_t c, bool* shifted) { ui::KeyboardCode KeyboardCodeFromStr(base::StringPiece str,
c = base::ToLowerASCII(c);
*shifted = false;
switch (c) {
case 0x08:
return ui::VKEY_BACK;
case 0x7F:
return ui::VKEY_DELETE;
case 0x09:
return ui::VKEY_TAB;
case 0x0D:
return ui::VKEY_RETURN;
case 0x1B:
return ui::VKEY_ESCAPE;
case ' ':
return ui::VKEY_SPACE;
case 'a':
return ui::VKEY_A;
case 'b':
return ui::VKEY_B;
case 'c':
return ui::VKEY_C;
case 'd':
return ui::VKEY_D;
case 'e':
return ui::VKEY_E;
case 'f':
return ui::VKEY_F;
case 'g':
return ui::VKEY_G;
case 'h':
return ui::VKEY_H;
case 'i':
return ui::VKEY_I;
case 'j':
return ui::VKEY_J;
case 'k':
return ui::VKEY_K;
case 'l':
return ui::VKEY_L;
case 'm':
return ui::VKEY_M;
case 'n':
return ui::VKEY_N;
case 'o':
return ui::VKEY_O;
case 'p':
return ui::VKEY_P;
case 'q':
return ui::VKEY_Q;
case 'r':
return ui::VKEY_R;
case 's':
return ui::VKEY_S;
case 't':
return ui::VKEY_T;
case 'u':
return ui::VKEY_U;
case 'v':
return ui::VKEY_V;
case 'w':
return ui::VKEY_W;
case 'x':
return ui::VKEY_X;
case 'y':
return ui::VKEY_Y;
case 'z':
return ui::VKEY_Z;
case ')':
*shifted = true;
[[fallthrough]];
case '0':
return ui::VKEY_0;
case '!':
*shifted = true;
[[fallthrough]];
case '1':
return ui::VKEY_1;
case '@':
*shifted = true;
[[fallthrough]];
case '2':
return ui::VKEY_2;
case '#':
*shifted = true;
[[fallthrough]];
case '3':
return ui::VKEY_3;
case '$':
*shifted = true;
[[fallthrough]];
case '4':
return ui::VKEY_4;
case '%':
*shifted = true;
[[fallthrough]];
case '5':
return ui::VKEY_5;
case '^':
*shifted = true;
[[fallthrough]];
case '6':
return ui::VKEY_6;
case '&':
*shifted = true;
[[fallthrough]];
case '7':
return ui::VKEY_7;
case '*':
*shifted = true;
[[fallthrough]];
case '8':
return ui::VKEY_8;
case '(':
*shifted = true;
[[fallthrough]];
case '9':
return ui::VKEY_9;
case ':':
*shifted = true;
[[fallthrough]];
case ';':
return ui::VKEY_OEM_1;
case '+':
*shifted = true;
[[fallthrough]];
case '=':
return ui::VKEY_OEM_PLUS;
case '<':
*shifted = true;
[[fallthrough]];
case ',':
return ui::VKEY_OEM_COMMA;
case '_':
*shifted = true;
[[fallthrough]];
case '-':
return ui::VKEY_OEM_MINUS;
case '>':
*shifted = true;
[[fallthrough]];
case '.':
return ui::VKEY_OEM_PERIOD;
case '?':
*shifted = true;
[[fallthrough]];
case '/':
return ui::VKEY_OEM_2;
case '~':
*shifted = true;
[[fallthrough]];
case '`':
return ui::VKEY_OEM_3;
case '{':
*shifted = true;
[[fallthrough]];
case '[':
return ui::VKEY_OEM_4;
case '|':
*shifted = true;
[[fallthrough]];
case '\\':
return ui::VKEY_OEM_5;
case '}':
*shifted = true;
[[fallthrough]];
case ']':
return ui::VKEY_OEM_6;
case '"':
*shifted = true;
[[fallthrough]];
case '\'':
return ui::VKEY_OEM_7;
default:
return ui::VKEY_UNKNOWN;
}
}
ui::KeyboardCode KeyboardCodeFromStr(const std::string& str,
absl::optional<char16_t>* shifted_char) { absl::optional<char16_t>* shifted_char) {
if (str.size() == 1) { auto const [code, shifted] =
bool shifted = false; str.size() == 1 ? KeyboardCodeFromCharCode(base::ToLowerASCII(str[0]))
auto ret = KeyboardCodeFromCharCode(str[0], &shifted); : KeyboardCodeFromKeyIdentifier(base::ToLowerASCII(str));
if (shifted)
shifted_char->emplace(str[0]); if (code == ui::VKEY_UNKNOWN)
return ret; LOG(WARNING) << "Invalid accelerator token: " << str;
} else {
return KeyboardCodeFromKeyIdentifier(str, shifted_char); *shifted_char = shifted;
} return code;
} }
} // namespace electron } // namespace electron

View file

@ -5,21 +5,16 @@
#ifndef ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_ #ifndef ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_
#define ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_ #define ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_
#include <string> #include "base/strings/string_piece.h"
#include "third_party/abseil-cpp/absl/types/optional.h" #include "third_party/abseil-cpp/absl/types/optional.h"
#include "ui/events/keycodes/keyboard_codes.h" #include "ui/events/keycodes/keyboard_codes.h"
namespace electron { namespace electron {
// Return key code of the char, and also determine whether the SHIFT key is
// pressed.
ui::KeyboardCode KeyboardCodeFromCharCode(char16_t c, bool* shifted);
// Return key code of the |str|, if the original key is a shifted character, // Return key code of the |str|, if the original key is a shifted character,
// for example + and /, set it in |shifted_char|. // for example + and /, set it in |shifted_char|.
// pressed. // pressed.
ui::KeyboardCode KeyboardCodeFromStr(const std::string& str, ui::KeyboardCode KeyboardCodeFromStr(base::StringPiece str,
absl::optional<char16_t>* shifted_char); absl::optional<char16_t>* shifted_char);
} // namespace electron } // namespace electron