refactor: convert crash reporter to gin (#17952)

This commit is contained in:
Jeremy Apthorp 2019-05-01 15:19:11 -07:00 committed by GitHub
parent 493af7f84c
commit 3949f0bd50
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 174 additions and 72 deletions

View file

@ -6,9 +6,10 @@
#define ATOM_COMMON_NATIVE_MATE_CONVERTERS_STRING16_CONVERTER_H_
#include "base/strings/string16.h"
#include "gin/converter.h"
#include "native_mate/converter.h"
namespace mate {
namespace gin {
template <>
struct Converter<base::string16> {
@ -36,6 +37,28 @@ inline v8::Local<v8::String> StringToV8(v8::Isolate* isolate,
return ConvertToV8(isolate, input).As<v8::String>();
}
} // namespace gin
namespace mate {
template <>
struct Converter<base::string16> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const base::string16& val) {
return gin::Converter<base::string16>::ToV8(isolate, val);
}
static bool FromV8(v8::Isolate* isolate,
v8::Local<v8::Value> val,
base::string16* out) {
return gin::Converter<base::string16>::FromV8(isolate, val, out);
}
};
inline v8::Local<v8::String> StringToV8(v8::Isolate* isolate,
const base::string16& input) {
return ConvertToV8(isolate, input).As<v8::String>();
}
} // namespace mate
#endif // ATOM_COMMON_NATIVE_MATE_CONVERTERS_STRING16_CONVERTER_H_