mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: ginify autoUpdater (#24678)

Browse source
This commit is contained in:
Jeremy Rose 2020-07-28 11:04:34 -07:00 • committed by GitHub
parent e6cf5906f6
commit 38fafe4986
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 68 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

11
shell/browser/auto_updater_mac.mm
View file

@ -41,14 +41,19 @@ std::string AutoUpdater::GetFeedURL() {
}
// static
void AutoUpdater::SetFeedURL(gin_helper::Arguments* args) {
void AutoUpdater::SetFeedURL(gin::Arguments* args) {
gin_helper::ErrorThrower thrower(args->isolate());
gin_helper::Dictionary opts;
std::string feed;
HeaderMap requestHeaders;
std::string serverType = "default";
if (args->GetNext(&opts)) {
v8::Local<v8::Value> first_arg = args->PeekNext();
if (!first_arg.IsEmpty() && first_arg->IsString()) {
if (args->GetNext(&feed)) {
args->GetNext(&requestHeaders);
}
} else if (args->GetNext(&opts)) {
if (!opts.Get("url", &feed)) {
thrower.ThrowError(
"Expected options object to contain a 'url' string property in "
@ -61,8 +66,6 @@ void AutoUpdater::SetFeedURL(gin_helper::Arguments* args) {
thrower.ThrowError("Expected serverType to be 'default' or 'json'");
return;
}
} else if (args->GetNext(&feed)) {
args->GetNext(&requestHeaders);
} else {
thrower.ThrowError(
"Expected an options object with a 'url' property to be provided");