refactor: remove base::Value from WebContentsPreferences (#30193)

shell/browser/web_contents_preferences.h

@@ -5,11 +5,15 @@
 #ifndef SHELL_BROWSER_WEB_CONTENTS_PREFERENCES_H_
 #define SHELL_BROWSER_WEB_CONTENTS_PREFERENCES_H_
 
+#include <map>
 #include <string>
 #include <vector>
 
 #include "base/values.h"
 #include "content/public/browser/web_contents_user_data.h"
+#include "electron/buildflags/buildflags.h"
+#include "third_party/blink/public/mojom/v8_cache_options.mojom-forward.h"
+#include "third_party/blink/public/mojom/webpreferences/web_preferences.mojom-forward.h"
 
 namespace base {
 class CommandLine;
@@ -32,14 +36,9 @@ class WebContentsPreferences
                          const gin_helper::Dictionary& web_preferences);
   ~WebContentsPreferences() override;
 
-  // Set WebPreferences defaults onto the JS object.
-  void SetDefaults();
+  void Merge(const gin_helper::Dictionary& new_web_preferences);
 
-  // A simple way to know whether a Boolean property is enabled.
-  bool IsEnabled(base::StringPiece name, bool default_value = false) const;
-
-  // $.extend(|web_preferences|, |new_web_preferences|).
-  void Merge(const base::DictionaryValue& new_web_preferences);
+  void SetFromDictionary(const gin_helper::Dictionary& new_web_preferences);
 
   // Append command paramters according to preferences.
   void AppendCommandLineSwitches(base::CommandLine* command_line,
@@ -48,19 +47,30 @@ class WebContentsPreferences
   // Modify the WebPreferences according to preferences.
   void OverrideWebkitPrefs(blink::web_pref::WebPreferences* prefs);
 
-  // Clear the current WebPreferences.
-  void Clear();
+  base::Value* last_preference() { return &last_web_preferences_; }
 
-  // Return true if the particular preference value exists.
-  bool GetPreference(base::StringPiece name, std::string* value) const;
-
-  // Returns the preload script path.
+  bool IsOffscreen() const { return offscreen_; }
+  SkColor GetBackgroundColor() const { return background_color_; }
+  void SetBackgroundColor(SkColor color) { background_color_ = color; }
+  bool ShouldUsePreferredSizeMode() const {
+    return enable_preferred_size_mode_;
+  }
+  void SetIgnoreMenuShortcuts(bool ignore_menu_shortcuts) {
+    ignore_menu_shortcuts_ = ignore_menu_shortcuts;
+  }
+  bool ShouldIgnoreMenuShortcuts() const { return ignore_menu_shortcuts_; }
+  bool SetImageAnimationPolicy(std::string policy);
+  bool ShouldDisableHtmlFullscreenWindowResize() const {
+    return disable_html_fullscreen_window_resize_;
+  }
+  bool ShouldDisableDialogs() const { return disable_dialogs_; }
+  bool ShouldUseSafeDialogs() const { return safe_dialogs_; }
+  bool GetSafeDialogsMessage(std::string* message) const;
+  bool ShouldDisablePopups() const { return disable_popups_; }
+  bool ShouldUseNativeWindowOpen() const { return native_window_open_; }
+  bool IsWebSecurityEnabled() const { return web_security_; }
   bool GetPreloadPath(base::FilePath* path) const;
 
-  // Returns the web preferences.
-  base::Value* preference() { return &preference_; }
-  base::Value* last_preference() { return &last_preference_; }
-
  private:
   friend class content::WebContentsUserData<WebContentsPreferences>;
   friend class ElectronBrowserClient;
@@ -68,21 +78,63 @@ class WebContentsPreferences
   // Get WebContents according to process ID.
   static content::WebContents* GetWebContentsFromProcessID(int process_id);
 
-  // Checks if the key is not defined
-  bool IsUndefined(base::StringPiece key);
-
-  // Set preference value to given bool if user did not provide value
-  bool SetDefaultBoolIfUndefined(base::StringPiece key, bool val);
-
-  // Set preference value to given bool
-  void SetBool(base::StringPiece key, bool value);
-
-  static std::vector<WebContentsPreferences*> instances_;
+  void Clear();
+  void SaveLastPreferences();
 
   content::WebContents* web_contents_;
 
-  base::Value preference_ = base::Value(base::Value::Type::DICTIONARY);
-  base::Value last_preference_ = base::Value(base::Value::Type::DICTIONARY);
+  bool plugins_;
+  bool experimental_features_;
+  bool node_integration_;
+  bool node_integration_in_sub_frames_;
+  bool node_integration_in_worker_;
+  bool disable_html_fullscreen_window_resize_;
+  bool webview_tag_;
+  bool sandbox_;
+  bool native_window_open_;
+  bool context_isolation_;
+  bool javascript_;
+  bool images_;
+  bool text_areas_are_resizable_;
+  bool webgl_;
+  bool enable_websql_;
+  bool enable_preferred_size_mode_;
+  bool web_security_;
+  bool allow_running_insecure_content_;
+  bool offscreen_;
+  bool navigate_on_drag_drop_;
+  blink::mojom::AutoplayPolicy autoplay_policy_;
+  std::map<std::string, std::u16string> default_font_family_;
+  absl::optional<int> default_font_size_;
+  absl::optional<int> default_monospace_font_size_;
+  absl::optional<int> minimum_font_size_;
+  absl::optional<std::string> default_encoding_;
+  int opener_id_;
+  int guest_instance_id_;
+  std::vector<std::string> custom_args_;
+  std::vector<std::string> custom_switches_;
+  absl::optional<std::string> enable_blink_features_;
+  absl::optional<std::string> disable_blink_features_;
+  bool disable_popups_;
+  bool disable_dialogs_;
+  bool safe_dialogs_;
+  absl::optional<std::string> safe_dialogs_message_;
+  bool ignore_menu_shortcuts_;
+  SkColor background_color_;
+  blink::mojom::ImageAnimationPolicy image_animation_policy_;
+  absl::optional<base::FilePath> preload_path_;
+  blink::mojom::V8CacheOptions v8_cache_options_;
+
+#if defined(OS_MAC)
+  bool scroll_bounce_;
+#endif
+#if BUILDFLAG(ENABLE_BUILTIN_SPELLCHECKER)
+  bool spellcheck_;
+#endif
+
+  // This is a snapshot of some relevant preferences at the time the renderer
+  // was launched.
+  base::Value last_web_preferences_;
 
   WEB_CONTENTS_USER_DATA_KEY_DECL();